Title: [240648] trunk/Source/WebDriver
- Revision
- 240648
- Author
- [email protected]
- Date
- 2019-01-29 02:37:06 -0800 (Tue, 29 Jan 2019)
Log Message
WebDriver: POST commands require a valid parameters object
https://bugs.webkit.org/show_bug.cgi?id=193906
Reviewed by Michael Catanzaro.
We are not failing when http body is empty.
Fixes tests: imported/w3c/webdriver/tests/set_window_rect/set.py::test_null_parameter_value
imported/w3c/webdriver/tests/set_timeouts/set.py::test_null_parameter_value
* WebDriverService.cpp:
(WebDriver::WebDriverService::handleRequest):
Modified Paths
Diff
Modified: trunk/Source/WebDriver/ChangeLog (240647 => 240648)
--- trunk/Source/WebDriver/ChangeLog 2019-01-29 07:55:42 UTC (rev 240647)
+++ trunk/Source/WebDriver/ChangeLog 2019-01-29 10:37:06 UTC (rev 240648)
@@ -1,3 +1,18 @@
+2019-01-29 Carlos Garcia Campos <[email protected]>
+
+ WebDriver: POST commands require a valid parameters object
+ https://bugs.webkit.org/show_bug.cgi?id=193906
+
+ Reviewed by Michael Catanzaro.
+
+ We are not failing when http body is empty.
+
+ Fixes tests: imported/w3c/webdriver/tests/set_window_rect/set.py::test_null_parameter_value
+ imported/w3c/webdriver/tests/set_timeouts/set.py::test_null_parameter_value
+
+ * WebDriverService.cpp:
+ (WebDriver::WebDriverService::handleRequest):
+
2019-01-04 Carlos Garcia Campos <[email protected]>
WebDriver: element click command should handle user prompts
Modified: trunk/Source/WebDriver/WebDriverService.cpp (240647 => 240648)
--- trunk/Source/WebDriver/WebDriverService.cpp 2019-01-29 07:55:42 UTC (rev 240647)
+++ trunk/Source/WebDriver/WebDriverService.cpp 2019-01-29 10:37:06 UTC (rev 240648)
@@ -236,7 +236,7 @@
}
RefPtr<JSON::Object> parametersObject;
- if (method.value() == HTTPMethod::Post && request.dataLength) {
+ if (method.value() == HTTPMethod::Post) {
RefPtr<JSON::Value> messageValue;
if (!JSON::Value::parseJSON(String::fromUTF8(request.data, request.dataLength), messageValue)) {
sendResponse(WTFMove(replyHandler), CommandResult::fail(CommandResult::ErrorCode::InvalidArgument));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
