Modified: trunk/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py (240889 => 240890)
--- trunk/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py 2019-02-02 00:45:51 UTC (rev 240889)
+++ trunk/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py 2019-02-02 02:19:43 UTC (rev 240890)
@@ -23,6 +23,7 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import json
import os
import unittest
@@ -34,7 +35,17 @@
cwd = os.path.dirname(os.path.abspath(__file__))
loadConfig.loadBuilderConfig({}, master_prefix_path=cwd)
+ def test_builder_keys(self):
+ cwd = os.path.dirname(os.path.abspath(__file__))
+ config = json.load(open(os.path.join(cwd, 'config.json')))
+ valid_builder_keys = ['additionalArguments', 'architectures', 'builddir', 'configuration', 'description',
+ 'defaultProperties', 'env', 'factory', 'locks', 'name', 'platform', 'properties', 'tags',
+ 'triggers', 'workernames', 'workerbuilddir']
+ for builder in config.get('builders', []):
+ for key in builder:
+ self.assertTrue(key in valid_builder_keys, 'Unexpected key {} for builder {}'.format(key, builder.get('name')))
+
class TagsForBuilderTeest(unittest.TestCase):
def verifyTags(self, builderName, expectedTags):
tags = loadConfig.getTagsForBuilder({'name': builderName})
Modified: trunk/Tools/ChangeLog (240889 => 240890)
--- trunk/Tools/ChangeLog 2019-02-02 00:45:51 UTC (rev 240889)
+++ trunk/Tools/ChangeLog 2019-02-02 02:19:43 UTC (rev 240890)
@@ -1,3 +1,13 @@
+2019-02-01 Aakash Jain <[email protected]>
+
+ [ews-build] Add unit test to verify builder keys
+ https://bugs.webkit.org/show_bug.cgi?id=194152
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
+ (ConfigDotJSONTest.test_builder_keys): Added unit-test.
+
2019-02-01 Zalan Bujtas <[email protected]>
[LFC] Expand tests coverage (12 new tests -> 787)
