Title: [240891] trunk/Source/WebCore
- Revision
- 240891
- Author
- [email protected]
- Date
- 2019-02-01 18:30:53 -0800 (Fri, 01 Feb 2019)
Log Message
Remove the unused layerForScrolling()
https://bugs.webkit.org/show_bug.cgi?id=194180
Reviewed by Zalan Bujtas.
Remove ScrollableArea::layerForScrolling() and derivations. This was unused.
* page/FrameView.cpp:
(WebCore::FrameView::layerForScrolling const): Deleted.
* page/FrameView.h:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea): Deleted.
* page/scrolling/ScrollingCoordinator.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::layerForScrolling const): Deleted.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
* rendering/RenderLayer.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (240890 => 240891)
--- trunk/Source/WebCore/ChangeLog 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/ChangeLog 2019-02-02 02:30:53 UTC (rev 240891)
@@ -1,3 +1,24 @@
+2019-02-01 Simon Fraser <[email protected]>
+
+ Remove the unused layerForScrolling()
+ https://bugs.webkit.org/show_bug.cgi?id=194180
+
+ Reviewed by Zalan Bujtas.
+
+ Remove ScrollableArea::layerForScrolling() and derivations. This was unused.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::layerForScrolling const): Deleted.
+ * page/FrameView.h:
+ * page/scrolling/ScrollingCoordinator.cpp:
+ (WebCore::ScrollingCoordinator::scrollLayerForScrollableArea): Deleted.
+ * page/scrolling/ScrollingCoordinator.h:
+ * platform/ScrollableArea.h:
+ (WebCore::ScrollableArea::layerForScrolling const): Deleted.
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::calculateClipRects const):
+ * rendering/RenderLayer.h:
+
2019-02-01 Zalan Bujtas <[email protected]>
[LFC] Fix statically positioned replaced out-of-flow horizontal geometry
Modified: trunk/Source/WebCore/page/FrameView.cpp (240890 => 240891)
--- trunk/Source/WebCore/page/FrameView.cpp 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/page/FrameView.cpp 2019-02-02 02:30:53 UTC (rev 240891)
@@ -848,14 +848,6 @@
renderView->compositor().updateCompositingLayers(CompositingUpdateType::AfterLayout);
}
-GraphicsLayer* FrameView::layerForScrolling() const
-{
- RenderView* renderView = this->renderView();
- if (!renderView)
- return nullptr;
- return renderView->compositor().scrollLayer();
-}
-
GraphicsLayer* FrameView::layerForHorizontalScrollbar() const
{
RenderView* renderView = this->renderView();
Modified: trunk/Source/WebCore/page/FrameView.h (240890 => 240891)
--- trunk/Source/WebCore/page/FrameView.h 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/page/FrameView.h 2019-02-02 02:30:53 UTC (rev 240891)
@@ -729,7 +729,6 @@
ScrollableArea* enclosingScrollableArea() const final;
IntRect scrollableAreaBoundingBox(bool* = nullptr) const final;
bool scrollAnimatorEnabled() const final;
- GraphicsLayer* layerForScrolling() const final;
GraphicsLayer* layerForScrollCorner() const final;
#if ENABLE(RUBBER_BANDING)
GraphicsLayer* layerForOverhangAreas() const final;
Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (240890 => 240891)
--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2019-02-02 02:30:53 UTC (rev 240891)
@@ -224,11 +224,6 @@
updateSynchronousScrollingReasons(frameView);
}
-GraphicsLayer* ScrollingCoordinator::scrollLayerForScrollableArea(ScrollableArea& scrollableArea)
-{
- return scrollableArea.layerForScrolling();
-}
-
GraphicsLayer* ScrollingCoordinator::scrollLayerForFrameView(FrameView& frameView)
{
if (auto* renderView = frameView.frame().contentRenderer())
Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h (240890 => 240891)
--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h 2019-02-02 02:30:53 UTC (rev 240891)
@@ -192,8 +192,6 @@
protected:
explicit ScrollingCoordinator(Page*);
- static GraphicsLayer* scrollLayerForScrollableArea(ScrollableArea&);
-
GraphicsLayer* scrollLayerForFrameView(FrameView&);
GraphicsLayer* counterScrollingLayerForFrameView(FrameView&);
GraphicsLayer* insetClipLayerForFrameView(FrameView&);
Modified: trunk/Source/WebCore/platform/ScrollableArea.h (240890 => 240891)
--- trunk/Source/WebCore/platform/ScrollableArea.h 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/platform/ScrollableArea.h 2019-02-02 02:30:53 UTC (rev 240891)
@@ -333,7 +333,6 @@
virtual void invalidateScrollCornerRect(const IntRect&) = 0;
friend class ScrollingCoordinator;
- virtual GraphicsLayer* layerForScrolling() const { return nullptr; }
virtual GraphicsLayer* layerForScrollCorner() const { return nullptr; }
#if ENABLE(RUBBER_BANDING)
virtual GraphicsLayer* layerForOverhangAreas() const { return nullptr; }
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (240890 => 240891)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2019-02-02 02:30:53 UTC (rev 240891)
@@ -5931,11 +5931,6 @@
return m_backing && m_backing->hasMaskLayer();
}
-GraphicsLayer* RenderLayer::layerForScrolling() const
-{
- return m_backing ? m_backing->scrollingContentsLayer() : nullptr;
-}
-
GraphicsLayer* RenderLayer::layerForHorizontalScrollbar() const
{
return m_backing ? m_backing->layerForHorizontalScrollbar() : nullptr;
Modified: trunk/Source/WebCore/rendering/RenderLayer.h (240890 => 240891)
--- trunk/Source/WebCore/rendering/RenderLayer.h 2019-02-02 02:19:43 UTC (rev 240890)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2019-02-02 02:30:53 UTC (rev 240891)
@@ -799,7 +799,6 @@
RenderLayerBacking* ensureBacking();
void clearBacking(bool layerBeingDestroyed = false);
- GraphicsLayer* layerForScrolling() const override;
GraphicsLayer* layerForHorizontalScrollbar() const override;
GraphicsLayer* layerForVerticalScrollbar() const override;
GraphicsLayer* layerForScrollCorner() const override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
