Title: [241216] trunk/Source/WebInspectorUI
- Revision
- 241216
- Author
- [email protected]
- Date
- 2019-02-08 15:51:52 -0800 (Fri, 08 Feb 2019)
Log Message
Web Inspector: Add Debug setting to show Internal Object Classes in Heap Snapshot
https://bugs.webkit.org/show_bug.cgi?id=194445
Patch by Joseph Pecoraro <[email protected]> on 2019-02-08
Reviewed by Devin Rousso.
* UserInterface/Base/Setting.js:
* UserInterface/Views/HeapSnapshotDataGridTree.js:
(WI.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createDebugSettingsView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (241215 => 241216)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-08 23:50:13 UTC (rev 241215)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-08 23:51:52 UTC (rev 241216)
@@ -1,3 +1,16 @@
+2019-02-08 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Add Debug setting to show Internal Object Classes in Heap Snapshot
+ https://bugs.webkit.org/show_bug.cgi?id=194445
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Views/HeapSnapshotDataGridTree.js:
+ (WI.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createDebugSettingsView):
+
2019-02-08 Nikita Vasilyev <[email protected]>
Web Inspector: Styles: close unbalanced quotes and parenthesis when editing values
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (241215 => 241216)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-02-08 23:50:13 UTC (rev 241215)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-02-08 23:51:52 UTC (rev 241216)
@@ -165,4 +165,5 @@
filterMultiplexingBackendInspectorProtocolMessages: new WI.Setting("filter-multiplexing-backend-inspector-protocol-messages", true),
layoutDirection: new WI.Setting("layout-direction-override", "system"),
pauseForInternalScripts: new WI.Setting("pause-for-internal-scripts", false),
+ debugShowInternalObjectsInHeapSnapshot: new WI.Setting("debug-show-internal-objects-in-heap-snapshot", false),
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js (241215 => 241216)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js 2019-02-08 23:50:13 UTC (rev 241215)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js 2019-02-08 23:51:52 UTC (rev 241216)
@@ -215,9 +215,12 @@
populateTopLevel()
{
- // Populate the first level with the different non-internal classes.
+ // Populate the first level with the different classes.
+ let skipInternalOnlyObjects = !WI.settings.debugShowInternalObjectsInHeapSnapshot.value;
+
for (let [className, {size, retainedSize, count, internalCount, deadCount}] of this.heapSnapshot.categories) {
- if (count === internalCount)
+ // Possibly skip internal only classes.
+ if (skipInternalOnlyObjects && count === internalCount)
continue;
// FIXME: <https://webkit.org/b/157905> Web Inspector: Provide a way to toggle between showing only live objects and live+dead objects
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (241215 => 241216)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-02-08 23:50:13 UTC (rev 241215)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-02-08 23:51:52 UTC (rev 241216)
@@ -317,6 +317,10 @@
this._debugSettingsView.addSeparator();
+ this._debugSettingsView.addSetting(WI.unlocalizedString("Heap Snapshot:"), WI.settings.debugShowInternalObjectsInHeapSnapshot, WI.unlocalizedString("Show Internal Objects"));
+
+ this._debugSettingsView.addSeparator();
+
this._debugSettingsView.addSetting(WI.unlocalizedString("Debugging:"), WI.settings.pauseForInternalScripts, WI.unlocalizedString("Pause in WebKit-internal scripts"));
this._debugSettingsView.addSetting(WI.unlocalizedString("Uncaught Exception Reporter:"), WI.settings.enableUncaughtExceptionReporter, WI.unlocalizedString("Enabled"));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
