Title: [241217] trunk/Source/_javascript_Core
- Revision
- 241217
- Author
- [email protected]
- Date
- 2019-02-08 16:21:56 -0800 (Fri, 08 Feb 2019)
Log Message
B3LowerMacros wrongly sets m_changed to true in the case of AtomicWeakCAS on x86
https://bugs.webkit.org/show_bug.cgi?id=194460
Reviewed by Mark Lam.
Trivial fix, should already be covered by testAtomicWeakCAS in testb3.cpp.
* b3/B3LowerMacros.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (241216 => 241217)
--- trunk/Source/_javascript_Core/ChangeLog 2019-02-08 23:51:52 UTC (rev 241216)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-02-09 00:21:56 UTC (rev 241217)
@@ -1,3 +1,14 @@
+2019-02-08 Robin Morisset <[email protected]>
+
+ B3LowerMacros wrongly sets m_changed to true in the case of AtomicWeakCAS on x86
+ https://bugs.webkit.org/show_bug.cgi?id=194460
+
+ Reviewed by Mark Lam.
+
+ Trivial fix, should already be covered by testAtomicWeakCAS in testb3.cpp.
+
+ * b3/B3LowerMacros.cpp:
+
2019-02-08 Mark Lam <[email protected]>
Use maxSingleCharacterString in comparisons instead of literal constants.
Modified: trunk/Source/_javascript_Core/b3/B3LowerMacros.cpp (241216 => 241217)
--- trunk/Source/_javascript_Core/b3/B3LowerMacros.cpp 2019-02-08 23:51:52 UTC (rev 241216)
+++ trunk/Source/_javascript_Core/b3/B3LowerMacros.cpp 2019-02-09 00:21:56 UTC (rev 241217)
@@ -230,6 +230,7 @@
m_insertionSet.insertIntConstant(m_index, expectedValue, mask(width)));
atomic->child(0) = maskedExpectedValue;
+ m_changed = true;
}
if (atomic->opcode() == AtomicStrongCAS) {
@@ -238,9 +239,9 @@
m_insertionSet.insertClone(m_index, atomic));
atomic->replaceWithIdentity(newValue);
+ m_changed = true;
}
-
- m_changed = true;
+
break;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
