Title: [241329] trunk/Tools
- Revision
- 241329
- Author
- [email protected]
- Date
- 2019-02-12 16:45:39 -0800 (Tue, 12 Feb 2019)
Log Message
webkitpy: Remove bug_dummy from parsed test expectations
https://bugs.webkit.org/show_bug.cgi?id=194562
<rdar://problem/47853999>
Reviewed by Lucas Forschler.
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
skipped tests.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (241328 => 241329)
--- trunk/Tools/ChangeLog 2019-02-13 00:23:10 UTC (rev 241328)
+++ trunk/Tools/ChangeLog 2019-02-13 00:45:39 UTC (rev 241329)
@@ -1,3 +1,17 @@
+2019-02-12 Jonathan Bedard <[email protected]>
+
+ webkitpy: Remove bug_dummy from parsed test expectations
+ https://bugs.webkit.org/show_bug.cgi?id=194562
+ <rdar://problem/47853999>
+
+ Reviewed by Lucas Forschler.
+
+ * Scripts/webkitpy/layout_tests/models/test_expectations.py:
+ (TestExpectationParser):
+ (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
+ skipped tests.
+ * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
+
2019-02-12 Aakash Jain <[email protected]>
[ews-app] Add method to fetch patch
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (241328 => 241329)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2019-02-13 00:23:10 UTC (rev 241328)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2019-02-13 00:45:39 UTC (rev 241329)
@@ -78,7 +78,6 @@
class TestExpectationParser(object):
"""Provides parsing facilities for lines in the test_expectation.txt file."""
- DUMMY_BUG_MODIFIER = "bug_dummy"
BUG_MODIFIER_PREFIX = 'bug'
BUG_MODIFIER_REGEX = 'bug\d+'
REBASELINE_MODIFIER = 'rebaseline'
@@ -117,7 +116,7 @@
_log.warning('The following test %s from the Skipped list doesn\'t exist' % test_name)
expectation_line = TestExpectationLine()
expectation_line.original_string = test_name
- expectation_line.modifiers = [TestExpectationParser.DUMMY_BUG_MODIFIER, TestExpectationParser.SKIP_MODIFIER]
+ expectation_line.modifiers = [TestExpectationParser.SKIP_MODIFIER]
# FIXME: It's not clear what the expectations for a skipped test should be; the expectations
# might be different for different entries in a Skipped file, or from the command line, or from
# only running parts of the tests. It's also not clear if it matters much.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py (241328 => 241329)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py 2019-02-13 00:23:10 UTC (rev 241328)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py 2019-02-13 00:45:39 UTC (rev 241329)
@@ -298,9 +298,9 @@
exp = TestExpectations(port, ['failures/expected/text.html'], expectations_to_lint=expectations_to_lint)
exp.parse_all_expectations()
- # Check that the expectation is for BUG_DUMMY SKIP : ... [ Pass ]
+ # Check that the expectation is for SKIP : ... [ Pass ]
self.assertEqual(exp.model().get_modifiers('failures/expected/text.html'),
- [TestExpectationParser.DUMMY_BUG_MODIFIER, TestExpectationParser.SKIP_MODIFIER, TestExpectationParser.WONTFIX_MODIFIER])
+ [TestExpectationParser.SKIP_MODIFIER, TestExpectationParser.WONTFIX_MODIFIER])
self.assertEqual(exp.model().get_expectations('failures/expected/text.html'), set([PASS]))
def test_skipped_tests_work(self):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
