Title: [241330] trunk/Source/WebKit
Revision
241330
Author
achristen...@apple.com
Date
2019-02-12 17:01:59 -0800 (Tue, 12 Feb 2019)

Log Message

Remove firing assertion after r241317
https://bugs.webkit.org/show_bug.cgi?id=194506

* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::setDefersLoading):
The creation of a PageGroupLoadDeferrer in Chrome.cpp tries to defer loading.
See comments in Chrome::runJavaScriptAlert et al.
This was necessary with WebKitLegacy, so keep it, but it doesn't need to do anything in modern WebKit.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (241329 => 241330)


--- trunk/Source/WebKit/ChangeLog	2019-02-13 00:45:39 UTC (rev 241329)
+++ trunk/Source/WebKit/ChangeLog	2019-02-13 01:01:59 UTC (rev 241330)
@@ -1,3 +1,14 @@
+2019-02-12  Alex Christensen  <achristen...@webkit.org>
+
+        Remove firing assertion after r241317
+        https://bugs.webkit.org/show_bug.cgi?id=194506
+
+        * WebProcess/Network/WebLoaderStrategy.cpp:
+        (WebKit::WebLoaderStrategy::setDefersLoading):
+        The creation of a PageGroupLoadDeferrer in Chrome.cpp tries to defer loading.
+        See comments in Chrome::runJavaScriptAlert et al.
+        This was necessary with WebKitLegacy, so keep it, but it doesn't need to do anything in modern WebKit.
+
 2019-02-12  Tim Horton  <timothy_hor...@apple.com>
 
         Find on Page shouldn't zoom in on matches

Modified: trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp (241329 => 241330)


--- trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	2019-02-13 00:45:39 UTC (rev 241329)
+++ trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	2019-02-13 01:01:59 UTC (rev 241330)
@@ -427,7 +427,6 @@
 
 void WebLoaderStrategy::setDefersLoading(ResourceLoader&, bool)
 {
-    ASSERT_NOT_REACHED();
 }
 
 void WebLoaderStrategy::crossOriginRedirectReceived(ResourceLoader*, const URL&)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to