[webkit-changes] [242130] trunk/LayoutTests

Wed, 27 Feb 2019 09:34:41 -0800

Title: [242130] trunk/LayoutTests
Revision
242130
Author
[email protected]
Date
2019-02-27 09:33:44 -0800 (Wed, 27 Feb 2019)

Log Message

scrolling/ios/hit-testing-iframe* tests need to hide the tap highlight
https://bugs.webkit.org/show_bug.cgi?id=195099

Reviewed by Frederic Wang.

These tests were failing because the ref test captured the tap highlight, so hide
it with -webkit-tap-highlight-color: transparent;

* fast/scrolling/ios/hit-testing-iframe-001.html:
* fast/scrolling/ios/hit-testing-iframe-002.html:
* fast/scrolling/ios/hit-testing-iframe-003.html:
* fast/scrolling/ios/hit-testing-iframe-004.html:
* fast/scrolling/ios/hit-testing-iframe-005.html:
* fast/scrolling/ios/hit-testing-iframe-006.html:
* fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html:
* platform/ios-wk2/TestExpectations: hit-testing-iframe-006.html passes now.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (242129 => 242130)


--- trunk/LayoutTests/ChangeLog	2019-02-27 17:31:46 UTC (rev 242129)
+++ trunk/LayoutTests/ChangeLog	2019-02-27 17:33:44 UTC (rev 242130)
@@ -1,3 +1,22 @@
+2019-02-27  Simon Fraser  <[email protected]>
+
+        scrolling/ios/hit-testing-iframe* tests need to hide the tap highlight
+        https://bugs.webkit.org/show_bug.cgi?id=195099
+
+        Reviewed by Frederic Wang.
+
+        These tests were failing because the ref test captured the tap highlight, so hide
+        it with -webkit-tap-highlight-color: transparent;
+
+        * fast/scrolling/ios/hit-testing-iframe-001.html:
+        * fast/scrolling/ios/hit-testing-iframe-002.html:
+        * fast/scrolling/ios/hit-testing-iframe-003.html:
+        * fast/scrolling/ios/hit-testing-iframe-004.html:
+        * fast/scrolling/ios/hit-testing-iframe-005.html:
+        * fast/scrolling/ios/hit-testing-iframe-006.html:
+        * fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html:
+        * platform/ios-wk2/TestExpectations: hit-testing-iframe-006.html passes now.
+
 2019-02-27  Ulrich Pflueger  <[email protected]>
 
         [MSE] SourceBuffer sample time increment vs. last frame duration check is broken

Modified: trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-001.html (242129 => 242130)


--- trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-001.html	2019-02-27 17:31:46 UTC (rev 242129)
+++ trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-001.html	2019-02-27 17:33:44 UTC (rev 242130)
@@ -36,8 +36,8 @@
     <p>This test passes if you see a green rectangle.</p>
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
       <iframe id="clickInContentBox" style="left: 0px; top: 0px;" scrolling="yes" _onclick_="this.style.background=''" srcdoc="
-          <body style='margin: 0; width: 200px; height: 200px'>
-              <div style='position: absolute; width: 100px; height: 100px; background: red;'
+          <body style='margin: 0; width: 200px; height: 200px;'>
+              <div style='position: absolute; width: 100px; height: 100px; background: red; -webkit-tap-highlight-color: transparent;'
                    _onclick_='this.style.background=""
           </body>" _onload_="runTest()">
       </iframe>

Modified: trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-002.html (242129 => 242130)


--- trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-002.html	2019-02-27 17:31:46 UTC (rev 242129)
+++ trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-002.html	2019-02-27 17:33:44 UTC (rev 242130)
@@ -37,7 +37,7 @@
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
       <iframe id="clickInPaddingBoxOutOfContentBox" style="left: 0px; top: 0px; background: red;" _onclick_="this.style.background=''" scrolling="yes" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px'>
-              <div style='position: absolute; width: 100px; height: 100px; background: green;'
+              <div style='position: absolute; width: 100px; height: 100px; background: green; -webkit-tap-highlight-color: transparent;'
                    _onclick_='this.style.background=""
           </body>" _onload_="runTest()">
       </iframe>

Modified: trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-003.html (242129 => 242130)


--- trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-003.html	2019-02-27 17:31:46 UTC (rev 242129)
+++ trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-003.html	2019-02-27 17:33:44 UTC (rev 242130)
@@ -37,7 +37,7 @@
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
       <iframe id="clickElementAboveFrame" style="left: 0px; top: 0px;" scrolling="yes" _onclick_="this.style.background=''" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px; background: green;'>
-              <div style='position: absolute; width: 100px; height: 100px; background: green;'
+              <div style='position: absolute; width: 100px; height: 100px; background: green; -webkit-tap-highlight-color: transparent;'
                    _onclick_='this.style.background=""
           </body>" _onload_="runTest()">
       </iframe>

Modified: trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-004.html (242129 => 242130)


--- trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-004.html	2019-02-27 17:31:46 UTC (rev 242129)
+++ trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-004.html	2019-02-27 17:33:44 UTC (rev 242130)
@@ -37,7 +37,7 @@
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
       <iframe id="clickElementInsideFrame" style="left: 0px; top: 0px;" scrolling="yes" _onclick_="this.style.background=''" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px; background: green;'>
-              <div style='position: absolute; left: 10px; top: 10px; width: 50px; height: 50px; background: red;'
+              <div style='position: absolute; left: 10px; top: 10px; width: 50px; height: 50px; background: red; -webkit-tap-highlight-color: transparent;'
                    _onclick_='this.style.background=""
           </body>" _onload_="runTest()">
       </iframe>

Modified: trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-005.html (242129 => 242130)


--- trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-005.html	2019-02-27 17:31:46 UTC (rev 242129)
+++ trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-005.html	2019-02-27 17:33:44 UTC (rev 242130)
@@ -40,7 +40,7 @@
       <iframe id="clickElementInsideFrameAfterProgrammaticScroll" style="left: 0px; top: 0px;" scrolling="yes" _onclick_="this.style.background=''" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px; background: green;'>
              <div style='position: absolute; width: 75px; height: 75px; background: red;'></div>
-              <div style='position: absolute; left: 110px; top: 110px; width: 50px; height: 50px; background: red;'
+              <div style='position: absolute; left: 110px; top: 110px; width: 50px; height: 50px; background: red; -webkit-tap-highlight-color: transparent;'
                    _onclick_='this.style.background=""
           </body>" _onload_="runTest()">
       </iframe>

Modified: trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-006.html (242129 => 242130)


--- trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-006.html	2019-02-27 17:31:46 UTC (rev 242129)
+++ trunk/LayoutTests/fast/scrolling/ios/hit-testing-iframe-006.html	2019-02-27 17:33:44 UTC (rev 242130)
@@ -48,7 +48,7 @@
       <iframe id="clickElementInsideFrameAfterUserScroll" style="left: 0px; top: 0px;" scrolling="yes" _onclick_="this.style.background=''" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px; background: green;'>
              <div style='position: absolute; width: 75px; height: 75px; background: red;'></div>
-              <div style='position: absolute; left: 0px; top: 150px; width: 50px; height: 50px; background: red;'
+              <div style='position: absolute; left: 0px; top: 150px; width: 50px; height: 50px; background: red; -webkit-tap-highlight-color: transparent;'
                    _onclick_='this.style.background=""
           </body>" _onload_="runTest()">
       </iframe>

Modified: trunk/LayoutTests/fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html (242129 => 242130)


--- trunk/LayoutTests/fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html	2019-02-27 17:31:46 UTC (rev 242129)
+++ trunk/LayoutTests/fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html	2019-02-27 17:33:44 UTC (rev 242130)
@@ -57,7 +57,7 @@
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
         <iframe id="programmaticYAndUserXAndHitTesting" style="left: 0px; top: 0px;" scrolling="yes" srcdoc="
             <body style='margin: 0; width: 200px; height: 200px'>
-                <div style='left: 100px; top: 100px; position: absolute; width: 100px; height: 100px; background: red;' _onclick_='this.style.background=""
+                <div style='left: 100px; top: 100px; position: absolute; width: 100px; height: 100px; background: red; -webkit-tap-highlight-color: transparent;' _onclick_='this.style.background=""
             </body>" _onload_="runTest()">
         </iframe>
     </div>

Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (242129 => 242130)


--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2019-02-27 17:31:46 UTC (rev 242129)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2019-02-27 17:33:44 UTC (rev 242130)
@@ -1075,7 +1075,6 @@
 webkit.org/b/153049 perf/array-binary-search.html [ Pass Failure Timeout ]
 
 fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html [ Pass Failure ]
-webkit.org/b/193997 fast/scrolling/ios/hit-testing-iframe-006.html [ ImageOnlyFailure ]
 
 webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]
 

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to