Title: [242131] trunk/Source/WebKit
- Revision
- 242131
- Author
- [email protected]
- Date
- 2019-02-27 10:05:06 -0800 (Wed, 27 Feb 2019)
Log Message
Silence log after r242122
https://bugs.webkit.org/show_bug.cgi?id=195074
* UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databasePath const):
m_localStorageDirectory can now be null for ephemeral sessions.
This is not a failure to create a directory and needs no log.
This fixes the WKWebView.InitializingWebViewWithEphemeralStorageDoesNotLog API test.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (242130 => 242131)
--- trunk/Source/WebKit/ChangeLog 2019-02-27 17:33:44 UTC (rev 242130)
+++ trunk/Source/WebKit/ChangeLog 2019-02-27 18:05:06 UTC (rev 242131)
@@ -1,3 +1,14 @@
+2019-02-27 Alex Christensen <[email protected]>
+
+ Silence log after r242122
+ https://bugs.webkit.org/show_bug.cgi?id=195074
+
+ * UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
+ (WebKit::LocalStorageDatabaseTracker::databasePath const):
+ m_localStorageDirectory can now be null for ephemeral sessions.
+ This is not a failure to create a directory and needs no log.
+ This fixes the WKWebView.InitializingWebViewWithEphemeralStorageDoesNotLog API test.
+
2019-02-27 Timothy Hatcher <[email protected]>
REGRESSION: WebKit content crash in Base System (because NSAppearance is NULL).
Modified: trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp (242130 => 242131)
--- trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp 2019-02-27 17:33:44 UTC (rev 242130)
+++ trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp 2019-02-27 18:05:06 UTC (rev 242131)
@@ -151,7 +151,8 @@
String LocalStorageDatabaseTracker::databasePath(const String& filename) const
{
if (!SQLiteFileSystem::ensureDatabaseDirectoryExists(m_localStorageDirectory)) {
- LOG_ERROR("Unable to create LocalStorage database path %s", m_localStorageDirectory.utf8().data());
+ if (!m_localStorageDirectory.isNull())
+ LOG_ERROR("Unable to create LocalStorage database path %s", m_localStorageDirectory.utf8().data());
return String();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
