Title: [243385] trunk/Tools
- Revision
- 243385
- Author
- [email protected]
- Date
- 2019-03-22 10:02:13 -0700 (Fri, 22 Mar 2019)
Log Message
[ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
https://bugs.webkit.org/show_bug.cgi?id=195348
<rdar://problem/48622090>
Reviewed by Alex Christensen.
Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
to NO when test.options().shouldIgnoreMetaViewport is false.
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformConfigureViewForTest):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (243384 => 243385)
--- trunk/Tools/ChangeLog 2019-03-22 17:01:14 UTC (rev 243384)
+++ trunk/Tools/ChangeLog 2019-03-22 17:02:13 UTC (rev 243385)
@@ -1,5 +1,19 @@
2019-03-22 Chris Dumez <[email protected]>
+ [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
+ https://bugs.webkit.org/show_bug.cgi?id=195348
+ <rdar://problem/48622090>
+
+ Reviewed by Alex Christensen.
+
+ Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
+ to NO when test.options().shouldIgnoreMetaViewport is false.
+
+ * WebKitTestRunner/ios/TestControllerIOS.mm:
+ (WTR::TestController::platformConfigureViewForTest):
+
+2019-03-22 Chris Dumez <[email protected]>
+
Prewarmed processes should be usable with any website data store
https://bugs.webkit.org/show_bug.cgi?id=196104
Modified: trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm (243384 => 243385)
--- trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2019-03-22 17:01:14 UTC (rev 243384)
+++ trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2019-03-22 17:02:13 UTC (rev 243385)
@@ -178,8 +178,7 @@
TestRunnerWKWebView *webView = mainWebView()->platformView();
- if (test.options().shouldIgnoreMetaViewport)
- webView.configuration.preferences._shouldIgnoreMetaViewport = YES;
+ webView.configuration.preferences._shouldIgnoreMetaViewport = test.options().shouldIgnoreMetaViewport;
CGRect screenBounds = [UIScreen mainScreen].bounds;
CGSize oldSize = webView.bounds.size;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes