Title: [243386] trunk
Revision
243386
Author
mark....@apple.com
Date
2019-03-22 10:21:37 -0700 (Fri, 22 Mar 2019)

Log Message

Placate exception check validation in constructJSWebAssemblyLinkError().
https://bugs.webkit.org/show_bug.cgi?id=196152
<rdar://problem/49145257>

Reviewed by Michael Saboff.

JSTests:

* stress/web-assembly-link-error-exception-check.js: Added.

Source/_javascript_Core:

* wasm/js/WebAssemblyLinkErrorConstructor.cpp:
(JSC::constructJSWebAssemblyLinkError):

Modified Paths

Added Paths

Diff

Modified: trunk/JSTests/ChangeLog (243385 => 243386)


--- trunk/JSTests/ChangeLog	2019-03-22 17:02:13 UTC (rev 243385)
+++ trunk/JSTests/ChangeLog	2019-03-22 17:21:37 UTC (rev 243386)
@@ -1,3 +1,13 @@
+2019-03-22  Mark Lam  <mark....@apple.com>
+
+        Placate exception check validation in constructJSWebAssemblyLinkError().
+        https://bugs.webkit.org/show_bug.cgi?id=196152
+        <rdar://problem/49145257>
+
+        Reviewed by Michael Saboff.
+
+        * stress/web-assembly-link-error-exception-check.js: Added.
+
 2019-03-22  Dominik Infuehr  <dinfu...@igalia.com>
 
         Skip tests running out of memory on ARM/MIPS

Added: trunk/JSTests/stress/web-assembly-link-error-exception-check.js (0 => 243386)


--- trunk/JSTests/stress/web-assembly-link-error-exception-check.js	                        (rev 0)
+++ trunk/JSTests/stress/web-assembly-link-error-exception-check.js	2019-03-22 17:21:37 UTC (rev 243386)
@@ -0,0 +1 @@
+new WebAssembly.LinkError([]);

Modified: trunk/Source/_javascript_Core/ChangeLog (243385 => 243386)


--- trunk/Source/_javascript_Core/ChangeLog	2019-03-22 17:02:13 UTC (rev 243385)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-03-22 17:21:37 UTC (rev 243386)
@@ -1,3 +1,14 @@
+2019-03-22  Mark Lam  <mark....@apple.com>
+
+        Placate exception check validation in constructJSWebAssemblyLinkError().
+        https://bugs.webkit.org/show_bug.cgi?id=196152
+        <rdar://problem/49145257>
+
+        Reviewed by Michael Saboff.
+
+        * wasm/js/WebAssemblyLinkErrorConstructor.cpp:
+        (JSC::constructJSWebAssemblyLinkError):
+
 2019-03-22  Timothy Hatcher  <timo...@apple.com>
 
         Change macosx() to macos() in WK_API... and JSC_API... macros.

Modified: trunk/Source/_javascript_Core/wasm/js/WebAssemblyLinkErrorConstructor.cpp (243385 => 243386)


--- trunk/Source/_javascript_Core/wasm/js/WebAssemblyLinkErrorConstructor.cpp	2019-03-22 17:02:13 UTC (rev 243385)
+++ trunk/Source/_javascript_Core/wasm/js/WebAssemblyLinkErrorConstructor.cpp	2019-03-22 17:21:37 UTC (rev 243386)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2016-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2016-2019 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -51,7 +51,7 @@
     JSValue message = exec->argument(0);
     auto* structure = InternalFunction::createSubclassStructure(exec, exec->newTarget(), jsCast<InternalFunction*>(exec->jsCallee())->globalObject(vm)->webAssemblyLinkErrorStructure());
     RETURN_IF_EXCEPTION(scope, encodedJSValue());
-    return JSValue::encode(JSWebAssemblyLinkError::create(exec, vm, structure, message));
+    RELEASE_AND_RETURN(scope, JSValue::encode(JSWebAssemblyLinkError::create(exec, vm, structure, message)));
 }
 
 static EncodedJSValue JSC_HOST_CALL callJSWebAssemblyLinkError(ExecState* exec)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to