Title: [243401] trunk/Source/WebCore
- Revision
- 243401
- Author
- you...@apple.com
- Date
- 2019-03-22 15:11:41 -0700 (Fri, 22 Mar 2019)
Log Message
storage/indexeddb/closed-cursor-private.html is crashing on debug
https://bugs.webkit.org/show_bug.cgi?id=196101
Reviewed by Alex Christensen.
In case of immediate close for user delete, the transaction might be deleted.
If the request for space is pending, it will be executed with an error as parameter.
In that case, the call to didCommitTransaction will not find any existing transaction.
Speculative fix, test should no longer crash.
* Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didCommitTransaction):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (243400 => 243401)
--- trunk/Source/WebCore/ChangeLog 2019-03-22 22:03:22 UTC (rev 243400)
+++ trunk/Source/WebCore/ChangeLog 2019-03-22 22:11:41 UTC (rev 243401)
@@ -1,3 +1,18 @@
+2019-03-22 Youenn Fablet <you...@apple.com>
+
+ storage/indexeddb/closed-cursor-private.html is crashing on debug
+ https://bugs.webkit.org/show_bug.cgi?id=196101
+
+ Reviewed by Alex Christensen.
+
+ In case of immediate close for user delete, the transaction might be deleted.
+ If the request for space is pending, it will be executed with an error as parameter.
+ In that case, the call to didCommitTransaction will not find any existing transaction.
+ Speculative fix, test should no longer crash.
+
+ * Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
+ (WebCore::IDBServer::UniqueIDBDatabaseConnection::didCommitTransaction):
+
2019-03-22 Devin Rousso <drou...@apple.com>
Web Inspector: Safari Canvas Inspector seems to show the canvas being rendered twice per frame.
Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp (243400 => 243401)
--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp 2019-03-22 22:03:22 UTC (rev 243400)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp 2019-03-22 22:11:41 UTC (rev 243401)
@@ -181,7 +181,7 @@
auto transactionIdentifier = transaction.info().identifier();
- ASSERT(m_transactionMap.contains(transactionIdentifier));
+ ASSERT(m_transactionMap.contains(transactionIdentifier) || !error.isNull());
m_transactionMap.remove(transactionIdentifier);
m_connectionToClient->didCommitTransaction(transactionIdentifier, error);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
