Title: [243402] trunk/Source/WebCore
- Revision
- 243402
- Author
- [email protected]
- Date
- 2019-03-22 15:12:32 -0700 (Fri, 22 Mar 2019)
Log Message
REGRESSION: Flaky ASSERTION FAILED: !m_killed seen with http/tests/security/cross-origin-worker-indexeddb.html
https://bugs.webkit.org/show_bug.cgi?id=196024
<rdar://problem/49117272>
Reviewed by Alexey Proskuryakov.
Do not proceed with opening the database if it is being closed.
Speculative fix, this should stop making test crashing on bots.
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (243401 => 243402)
--- trunk/Source/WebCore/ChangeLog 2019-03-22 22:11:41 UTC (rev 243401)
+++ trunk/Source/WebCore/ChangeLog 2019-03-22 22:12:32 UTC (rev 243402)
@@ -1,5 +1,19 @@
2019-03-22 Youenn Fablet <[email protected]>
+ REGRESSION: Flaky ASSERTION FAILED: !m_killed seen with http/tests/security/cross-origin-worker-indexeddb.html
+ https://bugs.webkit.org/show_bug.cgi?id=196024
+ <rdar://problem/49117272>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Do not proceed with opening the database if it is being closed.
+ Speculative fix, this should stop making test crashing on bots.
+
+ * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+ (WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
+
+2019-03-22 Youenn Fablet <[email protected]>
+
storage/indexeddb/closed-cursor-private.html is crashing on debug
https://bugs.webkit.org/show_bug.cgi?id=196101
Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (243401 => 243402)
--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2019-03-22 22:11:41 UTC (rev 243401)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2019-03-22 22:12:32 UTC (rev 243402)
@@ -220,6 +220,9 @@
if (!weakThis)
return;
+ if (m_owningPointerForClose)
+ return;
+
switch (decision) {
case StorageQuotaManager::Decision::Deny: {
auto result = IDBResultData::error(m_currentOpenDBRequest->requestData().requestIdentifier(), IDBError { QuotaExceededError, quotaErrorMessageName("openDatabase") });
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
