Title: [243864] trunk/Source/WebCore
- Revision
- 243864
- Author
- [email protected]
- Date
- 2019-04-03 22:53:30 -0700 (Wed, 03 Apr 2019)
Log Message
[ATK] Wrong index passed to AtkObject::children-changed::add signal in AXObjectCache::attachWrapper()
https://bugs.webkit.org/show_bug.cgi?id=196538
Reviewed by Michael Catanzaro.
In most of the cases the parent is not found, probably because the child is not a direct descendant of the
parent returned by parentObjectUnignored(). We need to handle the case of find() returning notFound.
* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::attachWrapper): Use -1 as the index when find() returns notFound.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (243863 => 243864)
--- trunk/Source/WebCore/ChangeLog 2019-04-04 05:52:44 UTC (rev 243863)
+++ trunk/Source/WebCore/ChangeLog 2019-04-04 05:53:30 UTC (rev 243864)
@@ -1,3 +1,16 @@
+2019-04-03 Carlos Garcia Campos <[email protected]>
+
+ [ATK] Wrong index passed to AtkObject::children-changed::add signal in AXObjectCache::attachWrapper()
+ https://bugs.webkit.org/show_bug.cgi?id=196538
+
+ Reviewed by Michael Catanzaro.
+
+ In most of the cases the parent is not found, probably because the child is not a direct descendant of the
+ parent returned by parentObjectUnignored(). We need to handle the case of find() returning notFound.
+
+ * accessibility/atk/AXObjectCacheAtk.cpp:
+ (WebCore::AXObjectCache::attachWrapper): Use -1 as the index when find() returns notFound.
+
2019-04-03 Timothy Hatcher <[email protected]>
Update AutoFill field icons to be SVG instead of PNG images.
Modified: trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp (243863 => 243864)
--- trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2019-04-04 05:52:44 UTC (rev 243863)
+++ trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2019-04-04 05:53:30 UTC (rev 243864)
@@ -99,7 +99,7 @@
return;
size_t index = coreParent->children(false).find(obj);
- g_signal_emit_by_name(atkParent, "children-changed::add", index, atkObj);
+ g_signal_emit_by_name(atkParent, "children-changed::add", index != notFound ? index : -1, atkObj);
}
static AccessibilityObject* getListObject(AccessibilityObject* object)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
