Title: [243867] trunk/Source/_javascript_Core
Revision
243867
Author
[email protected]
Date
2019-04-04 07:15:20 -0700 (Thu, 04 Apr 2019)

Log Message

UnlinkedCodeBlock constructor from cache should initialize m_didOptimize
https://bugs.webkit.org/show_bug.cgi?id=196396

Reviewed by Saam Barati.

The UnlinkedCodeBlock constructor in CachedTypes was missing the initialization
for m_didOptimize, which leads to crashes in CodeBlock::thresholdForJIT.

* runtime/CachedTypes.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (243866 => 243867)


--- trunk/Source/_javascript_Core/ChangeLog	2019-04-04 12:51:43 UTC (rev 243866)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-04-04 14:15:20 UTC (rev 243867)
@@ -1,3 +1,16 @@
+2019-04-04  Tadeu Zagallo  <[email protected]>
+
+        UnlinkedCodeBlock constructor from cache should initialize m_didOptimize
+        https://bugs.webkit.org/show_bug.cgi?id=196396
+
+        Reviewed by Saam Barati.
+
+        The UnlinkedCodeBlock constructor in CachedTypes was missing the initialization
+        for m_didOptimize, which leads to crashes in CodeBlock::thresholdForJIT.
+
+        * runtime/CachedTypes.cpp:
+        (JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
+
 2019-04-03  Yusuke Suzuki  <[email protected]>
 
         Unreviewed, rolling in r243843 with the build fix

Modified: trunk/Source/_javascript_Core/runtime/CachedTypes.cpp (243866 => 243867)


--- trunk/Source/_javascript_Core/runtime/CachedTypes.cpp	2019-04-04 12:51:43 UTC (rev 243866)
+++ trunk/Source/_javascript_Core/runtime/CachedTypes.cpp	2019-04-04 14:15:20 UTC (rev 243867)
@@ -1874,6 +1874,8 @@
     , m_hasTailCalls(cachedCodeBlock.hasTailCalls())
     , m_codeType(cachedCodeBlock.codeType())
 
+    , m_didOptimize(static_cast<unsigned>(MixedTriState))
+
     , m_features(cachedCodeBlock.features())
     , m_parseMode(cachedCodeBlock.parseMode())
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to