Title: [244282] trunk/Source/WebInspectorUI
- Revision
- 244282
- Author
- [email protected]
- Date
- 2019-04-15 12:56:59 -0700 (Mon, 15 Apr 2019)
Log Message
Web Inspector: REGRESSION(r244268): Canvas: navigation sidebar no longer appears
https://bugs.webkit.org/show_bug.cgi?id=196920
<rdar://problem/49910618>
Reviewed by Timothy Hatcher.
* UserInterface/Views/ContentBrowserTabContentView.js:
(WI.ContentBrowserTabContentView.prototype.showNavigationSidebarPanel):
Now that we no longer call `addSubview` when adding a sidebar panel, we can't check to see
if `parentSidebar` has been set, as that is just an alias for `parentView`.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (244281 => 244282)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-04-15 19:49:08 UTC (rev 244281)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-04-15 19:56:59 UTC (rev 244282)
@@ -1,5 +1,18 @@
2019-04-15 Devin Rousso <[email protected]>
+ Web Inspector: REGRESSION(r244268): Canvas: navigation sidebar no longer appears
+ https://bugs.webkit.org/show_bug.cgi?id=196920
+ <rdar://problem/49910618>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ContentBrowserTabContentView.js:
+ (WI.ContentBrowserTabContentView.prototype.showNavigationSidebarPanel):
+ Now that we no longer call `addSubview` when adding a sidebar panel, we can't check to see
+ if `parentSidebar` has been set, as that is just an alias for `parentView`.
+
+2019-04-15 Devin Rousso <[email protected]>
+
Web Inspector: DOMDebugger: move breakpoint storage to use `WI.ObjectStore`
https://bugs.webkit.org/show_bug.cgi?id=196231
<rdar://problem/49236864>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js (244281 => 244282)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js 2019-04-15 19:49:08 UTC (rev 244281)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js 2019-04-15 19:56:59 UTC (rev 244282)
@@ -154,14 +154,13 @@
if (shouldShowSidebar) {
if (!this.navigationSidebarPanel.parentSidebar)
WI.navigationSidebar.addSidebarPanel(this.navigationSidebarPanel);
- } else if (this.navigationSidebarPanel.parentSidebar)
- WI.navigationSidebar.removeSidebarPanel(this.navigationSidebarPanel);
-
- if (this.navigationSidebarPanel.parentSidebar) {
WI.navigationSidebar.selectedSidebarPanel = this.navigationSidebarPanel;
WI.navigationSidebar.collapsed = this.navigationSidebarCollapsedSetting.value;
- } else
+ } else {
WI.navigationSidebar.collapsed = true;
+ if (this.navigationSidebarPanel.parentSidebar)
+ WI.navigationSidebar.removeSidebarPanel(this.navigationSidebarPanel);
+ }
this._ignoreNavigationSidebarPanelCollapsedEvent = false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
