Title: [244283] trunk/Tools
- Revision
- 244283
- Author
- [email protected]
- Date
- 2019-04-15 13:12:39 -0700 (Mon, 15 Apr 2019)
Log Message
[ews-build] Do not run clean build by default on EWS builders
https://bugs.webkit.org/show_bug.cgi?id=196897
Reviewed by Lucas Forschler.
* BuildSlaveSupport/ews-build/steps.py:
(ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing
untracked directories like WebKitBuild).
(CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
untracked files/directories (like WebKitBuild).
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (244282 => 244283)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-04-15 19:56:59 UTC (rev 244282)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-04-15 20:12:39 UTC (rev 244283)
@@ -93,6 +93,7 @@
retry=self.CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR,
timeout=2 * 60 * 60,
alwaysUseLatest=True,
+ method='clean',
progress=True,
**kwargs)
@@ -133,7 +134,6 @@
return None
d = self.downloadFileContentToWorker('.buildbot-diff', patch)
- d.addCallback(lambda _: self.downloadFileContentToWorker('.buildbot-patched', 'patched\n'))
d.addCallback(lambda res: shell.ShellCommand.start(self))
def getResultSummary(self):
Modified: trunk/Tools/ChangeLog (244282 => 244283)
--- trunk/Tools/ChangeLog 2019-04-15 19:56:59 UTC (rev 244282)
+++ trunk/Tools/ChangeLog 2019-04-15 20:12:39 UTC (rev 244283)
@@ -1,3 +1,17 @@
+2019-04-15 Aakash Jain <[email protected]>
+
+ [ews-build] Do not run clean build by default on EWS builders
+ https://bugs.webkit.org/show_bug.cgi?id=196897
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
+ file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing
+ untracked directories like WebKitBuild).
+ (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
+ untracked files/directories (like WebKitBuild).
+
2019-04-15 Per Arne Vollan <[email protected]>
TestRunner::notifyDone() should be safely reentrant
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
