Title: [244655] trunk/Source/WebKit
- Revision
- 244655
- Author
- beid...@apple.com
- Date
- 2019-04-25 11:49:00 -0700 (Thu, 25 Apr 2019)
Log Message
REGRESSION (243388): WebProcess::shouldFreezeOnSuspension() decision is flipped
<rdar://problem/49755494> and https://bugs.webkit.org/show_bug.cgi?id=197284
Reviewed by Chris Dumez.
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::shouldFreezeOnSuspension const): If any non-suspended pages are in the process it should
be eligible. Only if all pages are suspended should it be jetsam-able.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (244654 => 244655)
--- trunk/Source/WebKit/ChangeLog 2019-04-25 18:15:47 UTC (rev 244654)
+++ trunk/Source/WebKit/ChangeLog 2019-04-25 18:49:00 UTC (rev 244655)
@@ -1,3 +1,14 @@
+2019-04-25 Brady Eidson <beid...@apple.com>
+
+ REGRESSION (243388): WebProcess::shouldFreezeOnSuspension() decision is flipped
+ <rdar://problem/49755494> and https://bugs.webkit.org/show_bug.cgi?id=197284
+
+ Reviewed by Chris Dumez.
+
+ * WebProcess/cocoa/WebProcessCocoa.mm:
+ (WebKit::WebProcess::shouldFreezeOnSuspension const): If any non-suspended pages are in the process it should
+ be eligible. Only if all pages are suspended should it be jetsam-able.
+
2019-04-25 Alex Christensen <achristen...@webkit.org>
Start using C++17
Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (244654 => 244655)
--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2019-04-25 18:15:47 UTC (rev 244654)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2019-04-25 18:49:00 UTC (rev 244655)
@@ -733,10 +733,11 @@
for (auto& page : m_pageMap.values()) {
if (!page->isSuspended())
- return false;
+ return true;
}
- return true;
+ // Since all of the pages in this process were suspended, we should not bother freezing it.
+ return false;
}
void WebProcess::updateFreezerStatus()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
