Title: [244656] trunk/Source
- Revision
- 244656
- Author
- [email protected]
- Date
- 2019-04-25 11:49:20 -0700 (Thu, 25 Apr 2019)
Log Message
Source/WebCore:
Fix MSVC build after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
* svg/properties/SVGValueProperty.h:
MSVC doesn't think it can access these protected constructors from subclasses.
Make the build work and investigate this later.
Source/WTF:
Fix High Sierra build after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
* wtf/StdLibExtras.h:
High Sierra thinks __cplusplus is 201406 even when using C++17.
Removing the __cplusplus check resolves the build failure on High Sierra.
We can clean up StdLibExtras more later.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (244655 => 244656)
--- trunk/Source/WTF/ChangeLog 2019-04-25 18:49:00 UTC (rev 244655)
+++ trunk/Source/WTF/ChangeLog 2019-04-25 18:49:20 UTC (rev 244656)
@@ -1,5 +1,15 @@
2019-04-25 Alex Christensen <[email protected]>
+ Fix High Sierra build after r244653
+ https://bugs.webkit.org/show_bug.cgi?id=197131
+
+ * wtf/StdLibExtras.h:
+ High Sierra thinks __cplusplus is 201406 even when using C++17.
+ Removing the __cplusplus check resolves the build failure on High Sierra.
+ We can clean up StdLibExtras more later.
+
+2019-04-25 Alex Christensen <[email protected]>
+
Start using C++17
https://bugs.webkit.org/show_bug.cgi?id=197131
Modified: trunk/Source/WTF/wtf/StdLibExtras.h (244655 => 244656)
--- trunk/Source/WTF/wtf/StdLibExtras.h 2019-04-25 18:49:00 UTC (rev 244655)
+++ trunk/Source/WTF/wtf/StdLibExtras.h 2019-04-25 18:49:20 UTC (rev 244656)
@@ -527,7 +527,7 @@
// Provide in_place_t when not building with -std=c++17, or when building with libstdc++ 6
// (which doesn't define the _GLIBCXX_RELEASE macro that's been introduced in libstdc++ 7).
-#if (__cplusplus < 201703L || (defined(__GLIBCXX__) && !defined(_GLIBCXX_RELEASE))) && (!defined(_MSVC_LANG) || _MSVC_LANG < 201703L)
+#if ((defined(__GLIBCXX__) && !defined(_GLIBCXX_RELEASE))) && (!defined(_MSVC_LANG) || _MSVC_LANG < 201703L)
// These are inline variable for C++17 and later.
#define __IN_PLACE_INLINE_VARIABLE static const
Modified: trunk/Source/WebCore/ChangeLog (244655 => 244656)
--- trunk/Source/WebCore/ChangeLog 2019-04-25 18:49:00 UTC (rev 244655)
+++ trunk/Source/WebCore/ChangeLog 2019-04-25 18:49:20 UTC (rev 244656)
@@ -1,5 +1,14 @@
2019-04-25 Alex Christensen <[email protected]>
+ Fix MSVC build after r244653
+ https://bugs.webkit.org/show_bug.cgi?id=197131
+
+ * svg/properties/SVGValueProperty.h:
+ MSVC doesn't think it can access these protected constructors from subclasses.
+ Make the build work and investigate this later.
+
+2019-04-25 Alex Christensen <[email protected]>
+
Start using C++17
https://bugs.webkit.org/show_bug.cgi?id=197131
Modified: trunk/Source/WebCore/svg/properties/SVGValueProperty.h (244655 => 244656)
--- trunk/Source/WebCore/svg/properties/SVGValueProperty.h 2019-04-25 18:49:00 UTC (rev 244655)
+++ trunk/Source/WebCore/svg/properties/SVGValueProperty.h 2019-04-25 18:49:20 UTC (rev 244656)
@@ -46,7 +46,11 @@
// Used by the SVGAnimatedPropertyAnimator to pass m_value to SVGAnimationFunction.
PropertyType& value() { return m_value; }
+ // Visual Studio doesn't seem to see these private constructors from subclasses.
+ // FIXME: See what it takes to remove this hack.
+#if !COMPILER(MSVC)
protected:
+#endif
// Create an initialized property, e.g creating an item to be appended in an SVGList.
SVGValueProperty(const PropertyType& value)
: m_value(value)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
