Title: [245819] trunk/Tools
Revision
245819
Author
[email protected]
Date
2019-05-28 12:06:18 -0700 (Tue, 28 May 2019)

Log Message

webkitpy: Using sudo on iOS device during timeout spindumps
https://bugs.webkit.org/show_bug.cgi?id=198142

Patch by David Xiong <[email protected]> on 2019-05-28
Reviewed by Jonathan Bedard.

* Scripts/webkitpy/port/darwin.py:
(DarwinPort.sample_process): Check target host instead of source host for sudo command.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (245818 => 245819)


--- trunk/Tools/ChangeLog	2019-05-28 18:11:52 UTC (rev 245818)
+++ trunk/Tools/ChangeLog	2019-05-28 19:06:18 UTC (rev 245819)
@@ -1,3 +1,13 @@
+2019-05-28  David Xiong  <[email protected]>
+
+        webkitpy: Using sudo on iOS device during timeout spindumps 
+        https://bugs.webkit.org/show_bug.cgi?id=198142
+
+        Reviewed by Jonathan Bedard.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort.sample_process): Check target host instead of source host for sudo command.
+
 2019-05-28  Aakash Jain  <[email protected]>
 
         [ews-build] Remove unused buildbot tabs

Modified: trunk/Tools/Scripts/webkitpy/port/darwin.py (245818 => 245819)


--- trunk/Tools/Scripts/webkitpy/port/darwin.py	2019-05-28 18:11:52 UTC (rev 245818)
+++ trunk/Tools/Scripts/webkitpy/port/darwin.py	2019-05-28 19:06:18 UTC (rev 245819)
@@ -168,7 +168,7 @@
             '-file',
             DarwinPort.spindump_file_path(host, name, pid, str(tempdir)),
         ]
-        if self.host.platform.is_mac():
+        if host.platform.is_mac():
             command = ['/usr/bin/sudo', '-n'] + command
         exit_status = host.executive.run_command(command, return_exit_code=True)
         if exit_status:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to