Title: [245820] trunk/LayoutTests
- Revision
- 245820
- Author
- [email protected]
- Date
- 2019-05-28 12:08:21 -0700 (Tue, 28 May 2019)
Log Message
[Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
https://bugs.webkit.org/show_bug.cgi?id=197008
Patch by Antoine Quint <[email protected]> on 2019-05-28
Reviewed by Jon Lee.
We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see https://github.com/w3c/pointerevents/issues/284
and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
the TestExpectations.
LayoutTests/imported/w3c:
* web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt:
* web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html:
LayoutTests:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (245819 => 245820)
--- trunk/LayoutTests/ChangeLog 2019-05-28 19:06:18 UTC (rev 245819)
+++ trunk/LayoutTests/ChangeLog 2019-05-28 19:08:21 UTC (rev 245820)
@@ -1,3 +1,16 @@
+2019-05-28 Antoine Quint <[email protected]>
+
+ [Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
+ https://bugs.webkit.org/show_bug.cgi?id=197008
+
+ Reviewed by Jon Lee.
+
+ We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see https://github.com/w3c/pointerevents/issues/284
+ and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
+ the TestExpectations.
+
+ * platform/mac/TestExpectations:
+
2019-05-28 Antti Koivisto <[email protected]>
[async scrolling] Fixed positioning inside stacking context overflow scroll is jumpy
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (245819 => 245820)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-05-28 19:06:18 UTC (rev 245819)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-05-28 19:08:21 UTC (rev 245820)
@@ -1,3 +1,17 @@
+2019-05-28 Antoine Quint <[email protected]>
+
+ [Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
+ https://bugs.webkit.org/show_bug.cgi?id=197008
+
+ Reviewed by Jon Lee.
+
+ We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see https://github.com/w3c/pointerevents/issues/284
+ and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
+ the TestExpectations.
+
+ * web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt:
+ * web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html:
+
2019-05-27 Oriol Brufau <[email protected]>
[css-grid] Preserve repeat() notation when serializing declared values
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt (245819 => 245820)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt 2019-05-28 19:06:18 UTC (rev 245819)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt 2019-05-28 19:08:21 UTC (rev 245820)
@@ -10,21 +10,11 @@
Done
The following pointer types were detected: mouse.
-The following events were logged: mouseup@target0, mousedown@target1, mousemove@target1, mouseup@target1.
+The following events were logged: mousedown@target1, mousemove@target1, mouseup@target1.
-Harness Error (FAIL), message = 1 duplicate test name: "mouseup's time stamp should be the same as pointerup's time stamp."
-
PASS Suppress compat mouse events on drag
PASS primary pointer pointerdown@target0
-PASS mouseup's time stamp should be the same as pointerup's time stamp.
-PASS Pointer Event: Suppress compatibility mouse events on drag
PASS primary pointer pointerdown@target1
-PASS mousedown's time stamp should be the same as pointerdown's time stamp.
-PASS Pointer Event: Suppress compatibility mouse events on drag 1
-PASS mousemove's time stamp should be the same as pointermove's time stamp.
-FAIL Pointer Event: Suppress compatibility mouse events on drag 2 assert_equals: The time stamp of the compat mouse event should be the same as its pointerevent expected 100 but got 99
-PASS mouseup's time stamp should be the same as pointerup's time stamp.
-PASS Pointer Event: Suppress compatibility mouse events on drag 3
-FAIL Event log assert_equals: expected "mousedown@target1, mousemove@target1, mouseup@target1" but got "mouseup@target0, mousedown@target1, mousemove@target1, mouseup@target1"
+PASS Event log
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html (245819 => 245820)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html 2019-05-28 19:06:18 UTC (rev 245819)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html 2019-05-28 19:08:21 UTC (rev 245820)
@@ -46,7 +46,6 @@
var target_list = ["target0", "target1"];
var pointer_event_list = ["pointerdown" , "pointermove", "pointerup"];
var mouse_event_list = ["mousedown", "mouseup", "mousemove"];
- var last_pointer_event = null;
target_list.forEach(function(targetId) {
var target = document.getElementById(targetId);
@@ -64,8 +63,6 @@
if (label === "pointerdown@target0")
event.preventDefault();
-
- last_pointer_event = event;
});
});
@@ -77,11 +74,6 @@
event_log.push(event.type + "@" + targetId);
include_next_mousemove = (event.type == "mousedown");
- test(function() {
- test(function () {
- assert_equals(event.timeStamp, last_pointer_event.timeStamp, "The time stamp of the compat mouse event should be the same as its pointerevent");
- });
- }, event.type + "'s time stamp should be the same as " + last_pointer_event.type + "'s time stamp.");
});
});
});
Modified: trunk/LayoutTests/platform/mac/TestExpectations (245819 => 245820)
--- trunk/LayoutTests/platform/mac/TestExpectations 2019-05-28 19:06:18 UTC (rev 245819)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2019-05-28 19:08:21 UTC (rev 245820)
@@ -1880,7 +1880,6 @@
imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-manual.html [ Skip ]
webkit.org/b/197005 imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_is_first.html [ Skip ]
-webkit.org/b/197008 imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html [ Pass Failure ]
webkit.org/b/197007 imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_coordinates_when_locked.html [ Skip ]
webkit.org/b/197009 imported/w3c/web-platform-tests/pointerevents/pointerevent_setpointercapture_invalid_pointerid.html [ Failure Pass ]
webkit.org/b/197058 imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_in_frame.html [ Failure Pass ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
