Title: [245821] trunk/LayoutTests
- Revision
- 245821
- Author
- [email protected]
- Date
- 2019-05-28 12:10:23 -0700 (Tue, 28 May 2019)
Log Message
REGRESSION (r244182): inspector/canvas/recording-webgl-snapshots.html became flaky on WK1
https://bugs.webkit.org/show_bug.cgi?id=196875
<rdar://problem/49873252>
Reviewed by Said Abou-Hallawa.
Remove the `frameLimit` configuration on these tests, as they're short enough that when
running in debug, the timing between the `InspectorCanvasAgent` automatically stopping the
recording and the test page's `LastFrame` event (which will manually stop the recording) is
too close and can result in a race condition.
Instead, just wait for the test page to say "done" (`LastFrame`) before stopping the
recording, ensuring that the full "flow" of the recording is under the control of the test.
This isn't an issue when using Web Inspector "normally" (e.g. not in a test), because the
frontend UI will "ignore" these types of errors, not to mention it would be much harder for
a person to get the timing just right to even encounter this situation.
* inspector/canvas/recording-webgl-snapshots.html:
* inspector/canvas/recording-webgl2-snapshots.html:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (245820 => 245821)
--- trunk/LayoutTests/ChangeLog 2019-05-28 19:08:21 UTC (rev 245820)
+++ trunk/LayoutTests/ChangeLog 2019-05-28 19:10:23 UTC (rev 245821)
@@ -1,3 +1,27 @@
+2019-05-28 Devin Rousso <[email protected]>
+
+ REGRESSION (r244182): inspector/canvas/recording-webgl-snapshots.html became flaky on WK1
+ https://bugs.webkit.org/show_bug.cgi?id=196875
+ <rdar://problem/49873252>
+
+ Reviewed by Said Abou-Hallawa.
+
+ Remove the `frameLimit` configuration on these tests, as they're short enough that when
+ running in debug, the timing between the `InspectorCanvasAgent` automatically stopping the
+ recording and the test page's `LastFrame` event (which will manually stop the recording) is
+ too close and can result in a race condition.
+
+ Instead, just wait for the test page to say "done" (`LastFrame`) before stopping the
+ recording, ensuring that the full "flow" of the recording is under the control of the test.
+
+ This isn't an issue when using Web Inspector "normally" (e.g. not in a test), because the
+ frontend UI will "ignore" these types of errors, not to mention it would be much harder for
+ a person to get the timing just right to even encounter this situation.
+
+ * inspector/canvas/recording-webgl-snapshots.html:
+ * inspector/canvas/recording-webgl2-snapshots.html:
+ * platform/mac/TestExpectations:
+
2019-05-28 Antoine Quint <[email protected]>
[Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
Modified: trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html (245820 => 245821)
--- trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html 2019-05-28 19:08:21 UTC (rev 245820)
+++ trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html 2019-05-28 19:10:23 UTC (rev 245821)
@@ -100,7 +100,7 @@
name: "Canvas.recordingWebGL.snapshots",
description: "Check that the snapshot taken after each visual action is different.",
test(resolve, reject) {
- startRecording(WI.Canvas.ContextType.WebGL, resolve, reject, {frameCount: 1, checkForContentChange: true});
+ startRecording(WI.Canvas.ContextType.WebGL, resolve, reject, {checkForContentChange: true});
},
timeout: -1,
});
Modified: trunk/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html (245820 => 245821)
--- trunk/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html 2019-05-28 19:08:21 UTC (rev 245820)
+++ trunk/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html 2019-05-28 19:10:23 UTC (rev 245821)
@@ -102,7 +102,7 @@
name: "Canvas.recordingWebGL2.snapshots",
description: "Check that the snapshot taken after each visual action is different.",
test(resolve, reject) {
- startRecording(WI.Canvas.ContextType.WebGL2, resolve, reject, {frameCount: 1, checkForContentChange: true});
+ startRecording(WI.Canvas.ContextType.WebGL2, resolve, reject, {checkForContentChange: true});
},
timeout: -1,
});
Modified: trunk/LayoutTests/platform/mac/TestExpectations (245820 => 245821)
--- trunk/LayoutTests/platform/mac/TestExpectations 2019-05-28 19:08:21 UTC (rev 245820)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2019-05-28 19:10:23 UTC (rev 245821)
@@ -1811,8 +1811,6 @@
webkit.org/b/196517 imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html [ Skip ]
-webkit.org/b/196875 inspector/canvas/recording-webgl-snapshots.html [ Pass Failure ]
-
webkit.org/b/177663 media/W3C/video/events/event_progress_manual.html [ Pass Failure ]
# Skip iOS-specific Pointer Events WPT tests.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
