Title: [246027] trunk/LayoutTests
- Revision
- 246027
- Author
- [email protected]
- Date
- 2019-06-02 19:12:59 -0700 (Sun, 02 Jun 2019)
Log Message
Flaky Test: inspector/canvas/recording.html
https://bugs.webkit.org/show_bug.cgi?id=198470
Reviewed by Matt Baker.
* inspector/canvas/recording.html:
Don't rely on `frameCount` to automatically stop the recording, as that's dependent on when
the <canvas> paints and is less controllable/deterministic.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (246026 => 246027)
--- trunk/LayoutTests/ChangeLog 2019-06-03 00:05:10 UTC (rev 246026)
+++ trunk/LayoutTests/ChangeLog 2019-06-03 02:12:59 UTC (rev 246027)
@@ -1,3 +1,14 @@
+2019-06-02 Devin Rousso <[email protected]>
+
+ Flaky Test: inspector/canvas/recording.html
+ https://bugs.webkit.org/show_bug.cgi?id=198470
+
+ Reviewed by Matt Baker.
+
+ * inspector/canvas/recording.html:
+ Don't rely on `frameCount` to automatically stop the recording, as that's dependent on when
+ the <canvas> paints and is less controllable/deterministic.
+
2019-06-01 Simon Fraser <[email protected]>
[Async overflow scroll] Flashing content when scrolling async overflow with a negative z-index child
Modified: trunk/LayoutTests/inspector/canvas/recording.html (246026 => 246027)
--- trunk/LayoutTests/inspector/canvas/recording.html 2019-06-03 00:05:10 UTC (rev 246026)
+++ trunk/LayoutTests/inspector/canvas/recording.html 2019-06-03 02:12:59 UTC (rev 246027)
@@ -44,11 +44,12 @@
canvas.awaitEvent(WI.Canvas.Event.RecordingStarted)
.then((event) => {
InspectorTest.evaluateInPage(`performActionsNaN()`);
- });
- const frameCount = 1;
- CanvasAgent.startRecording(canvas.identifier, frameCount)
+ canvas.stopRecording();
+ })
.catch(reject);
+
+ canvas.startRecording();
},
});
@@ -56,8 +57,6 @@
name: "Canvas.MultipleRecording",
description: "Check that multiple recordings are able to be started/stopped at the same time.",
test(resolve, reject) {
- const singleFrame = false;
-
let canvases = WI.canvasManager.canvases;
InspectorTest.assert(canvases.length === 2, "There should be two canvas contexts.");
@@ -73,7 +72,8 @@
InspectorTest.log("Stopping the recording of canvas 2...");
canvases[1].stopRecording();
- });
+ })
+ .catch(reject);
InspectorTest.awaitEvent("TestPage-performActionsMultiple")
.then((event) => {
@@ -81,7 +81,8 @@
InspectorTest.log("Stopping the recording of canvas 1...");
canvases[0].stopRecording();
- });
+ })
+ .catch(reject);
canvases[1].awaitEvent(WI.Canvas.Event.RecordingStarted)
.then((event) => {
@@ -89,7 +90,8 @@
InspectorTest.log("Performing actions...");
InspectorTest.evaluateInPage(`performActionsMultiple()`);
- });
+ })
+ .catch(reject);
canvases[0].awaitEvent(WI.Canvas.Event.RecordingStarted)
.then((event) => {
@@ -96,11 +98,12 @@
InspectorTest.expectThat(canvases[0].recordingActive, "Recording started of canvas 1");
InspectorTest.log("Starting a recording of canvas 2...");
- canvases[1].startRecording(singleFrame);
- });
+ canvases[1].startRecording();
+ })
+ .catch(reject);
InspectorTest.log("Starting a recording of canvas 1...");
- canvases[0].startRecording(singleFrame);
+ canvases[0].startRecording();
},
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
