Title: [246028] trunk/Tools
- Revision
- 246028
- Author
- [email protected]
- Date
- 2019-06-02 22:28:58 -0700 (Sun, 02 Jun 2019)
Log Message
[WinCairo][MiniBrowser] WKViewSetIsInWindow should be called
https://bugs.webkit.org/show_bug.cgi?id=198474
Reviewed by Darin Adler.
WinCairo WK2 MiniBrowser can't play back videos because
Page::canStartMedia() always returns false. WKViewSetIsInWindow
should be called.
The original MiniBrowser did it in Bug 55364.
* MiniBrowser/win/WebKitBrowserWindow.cpp:
(WebKitBrowserWindow::WebKitBrowserWindow): Call WKViewSetIsInWindow.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (246027 => 246028)
--- trunk/Tools/ChangeLog 2019-06-03 02:12:59 UTC (rev 246027)
+++ trunk/Tools/ChangeLog 2019-06-03 05:28:58 UTC (rev 246028)
@@ -1,3 +1,19 @@
+2019-06-02 Fujii Hironori <[email protected]>
+
+ [WinCairo][MiniBrowser] WKViewSetIsInWindow should be called
+ https://bugs.webkit.org/show_bug.cgi?id=198474
+
+ Reviewed by Darin Adler.
+
+ WinCairo WK2 MiniBrowser can't play back videos because
+ Page::canStartMedia() always returns false. WKViewSetIsInWindow
+ should be called.
+
+ The original MiniBrowser did it in Bug 55364.
+
+ * MiniBrowser/win/WebKitBrowserWindow.cpp:
+ (WebKitBrowserWindow::WebKitBrowserWindow): Call WKViewSetIsInWindow.
+
2019-05-31 Sihui Liu <[email protected]>
TestWebKitAPI.WKWebView.LocalStorageProcessSuspends is flaky
Modified: trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp (246027 => 246028)
--- trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp 2019-06-03 02:12:59 UTC (rev 246027)
+++ trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp 2019-06-03 05:28:58 UTC (rev 246028)
@@ -129,6 +129,8 @@
{
RECT rect = { };
m_view = adoptWK(WKViewCreate(rect, conf, mainWnd));
+ WKViewSetIsInWindow(m_view.get(), true);
+
auto page = WKViewGetPage(m_view.get());
WKPageNavigationClientV0 navigationClient = { };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
