Title: [246088] trunk/Source/WebKit
- Revision
- 246088
- Author
- [email protected]
- Date
- 2019-06-04 16:44:48 -0700 (Tue, 04 Jun 2019)
Log Message
Turn on background color estimation for all link indicators
https://bugs.webkit.org/show_bug.cgi?id=198547
<rdar://problem/51140196>
Reviewed by Dean Jackson.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::computeAndSendEditDragSnapshot):
(WebKit::linkIndicatorPositionInformation):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (246087 => 246088)
--- trunk/Source/WebKit/ChangeLog 2019-06-04 23:31:34 UTC (rev 246087)
+++ trunk/Source/WebKit/ChangeLog 2019-06-04 23:44:48 UTC (rev 246088)
@@ -1,5 +1,17 @@
2019-06-04 Tim Horton <[email protected]>
+ Turn on background color estimation for all link indicators
+ https://bugs.webkit.org/show_bug.cgi?id=198547
+ <rdar://problem/51140196>
+
+ Reviewed by Dean Jackson.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::computeAndSendEditDragSnapshot):
+ (WebKit::linkIndicatorPositionInformation):
+
+2019-06-04 Tim Horton <[email protected]>
+
Remove some unused selection code
https://bugs.webkit.org/show_bug.cgi?id=198451
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (246087 => 246088)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-06-04 23:31:34 UTC (rev 246087)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-06-04 23:44:48 UTC (rev 246088)
@@ -876,7 +876,7 @@
void WebPage::computeAndSendEditDragSnapshot()
{
Optional<TextIndicatorData> textIndicatorData;
- static auto defaultTextIndicatorOptionsForEditDrag = TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection | TextIndicatorOptionExpandClipBeyondVisibleRect | TextIndicatorOptionPaintAllContent | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection | TextIndicatorOptionPaintBackgrounds | TextIndicatorOptionComputeEstimatedBackgroundColor| TextIndicatorOptionUseSelectionRectForSizing | TextIndicatorOptionIncludeSnapshotWithSelectionHighlight;
+ static auto defaultTextIndicatorOptionsForEditDrag = TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection | TextIndicatorOptionExpandClipBeyondVisibleRect | TextIndicatorOptionPaintAllContent | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection | TextIndicatorOptionPaintBackgrounds | TextIndicatorOptionComputeEstimatedBackgroundColor | TextIndicatorOptionUseSelectionRectForSizing | TextIndicatorOptionIncludeSnapshotWithSelectionHighlight;
if (auto range = std::exchange(m_rangeForDropSnapshot, nullptr)) {
if (auto textIndicator = TextIndicator::createWithRange(*range, defaultTextIndicatorOptionsForEditDrag, TextIndicatorPresentationTransition::None, { }))
textIndicatorData = textIndicator->data();
@@ -2433,7 +2433,7 @@
auto textIndicator = TextIndicator::createWithRange(linkRange.get(),
TextIndicatorOptionTightlyFitContent | TextIndicatorOptionRespectTextColor | TextIndicatorOptionPaintBackgrounds |
- TextIndicatorOptionUseBoundingRectAndPaintAllContentForComplexRanges | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection,
+ TextIndicatorOptionUseBoundingRectAndPaintAllContentForComplexRanges | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection | TextIndicatorOptionComputeEstimatedBackgroundColor,
TextIndicatorPresentationTransition::None, FloatSize(marginInPoints * deviceScaleFactor, marginInPoints * deviceScaleFactor));
if (textIndicator)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
