Title: [246089] trunk/LayoutTests
- Revision
- 246089
- Author
- [email protected]
- Date
- 2019-06-04 17:11:10 -0700 (Tue, 04 Jun 2019)
Log Message
Layout test landed flaky in 245873 [ Release ] http/wpt/service-workers/service-worker-networkprocess-crash.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=198435
<rdar://problem/51314295>
Reviewed by Alex Christensen.
Make the test more robust by retrying the null test more than once.
* http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt:
* http/wpt/service-workers/service-worker-networkprocess-crash.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (246088 => 246089)
--- trunk/LayoutTests/ChangeLog 2019-06-04 23:44:48 UTC (rev 246088)
+++ trunk/LayoutTests/ChangeLog 2019-06-05 00:11:10 UTC (rev 246089)
@@ -1,3 +1,16 @@
+2019-06-04 Youenn Fablet <[email protected]>
+
+ Layout test landed flaky in 245873 [ Release ] http/wpt/service-workers/service-worker-networkprocess-crash.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=198435
+ <rdar://problem/51314295>
+
+ Reviewed by Alex Christensen.
+
+ Make the test more robust by retrying the null test more than once.
+
+ * http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt:
+ * http/wpt/service-workers/service-worker-networkprocess-crash.html:
+
2019-06-04 Chris Dumez <[email protected]>
Crash when calling XMLHttpRequest.setRequestHeader() in a worker
Modified: trunk/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt (246088 => 246089)
--- trunk/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt 2019-06-04 23:44:48 UTC (rev 246088)
+++ trunk/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt 2019-06-05 00:11:10 UTC (rev 246089)
@@ -1,4 +1,5 @@
+
PASS Setup worker
PASS Frame being controlled
PASS Frame being controlled after network process crash
Modified: trunk/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash.html (246088 => 246089)
--- trunk/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash.html 2019-06-04 23:44:48 UTC (rev 246088)
+++ trunk/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash.html 2019-06-05 00:11:10 UTC (rev 246089)
@@ -48,9 +48,15 @@
if (window.testRunner && window.testRunner.terminateNetworkProcess)
testRunner.terminateNetworkProcess();
- const frame = await withFrame(scope + "/empty.html");
- assert_not_equals(frame.contentWindow.navigator.serviceWorker.controller, null);
- frame.remove();
+ let count = 0;
+ while (count++ < 20) {
+ const frame = await withFrame(scope + "/empty.html");
+ if (frame.contentWindow.navigator.serviceWorker.controller)
+ break;
+ frame.remove();
+ await new Promise(resolve => setTimeout(resolve, 50));
+ }
+ assert_true(count < 20);
}, "Frame being controlled after network process crash");
</script>
</body>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
