Title: [246266] trunk/Source/_javascript_Core
Revision
246266
Author
[email protected]
Date
2019-06-10 10:16:18 -0700 (Mon, 10 Jun 2019)

Log Message

[JSC] Linker fails when unified sources are not in use
https://bugs.webkit.org/show_bug.cgi?id=198722

Reviewed by Keith Miller.

Added missing inclusions of headers in several files which make use of inline functions.

* b3/B3AtomicValue.cpp:
* b3/B3BlockInsertionSet.cpp:
* b3/B3FenceValue.cpp:
* b3/B3LowerMacrosAfterOptimizations.cpp:
* b3/B3PureCSE.cpp:
* b3/B3StackmapValue.cpp:
* b3/B3SwitchValue.cpp:
* b3/B3UseCounts.cpp:
* b3/B3VariableValue.cpp:
* b3/B3WasmAddressValue.cpp:
* b3/B3WasmBoundsCheckValue.cpp:
* ftl/FTLCompile.cpp:
* wasm/WasmSectionParser.cpp:
* wasm/WasmTable.cpp:
* wasm/WasmValidate.cpp:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (246265 => 246266)


--- trunk/Source/_javascript_Core/ChangeLog	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-06-10 17:16:18 UTC (rev 246266)
@@ -1,3 +1,28 @@
+2019-06-10  Adrian Perez de Castro  <[email protected]>
+
+        [JSC] Linker fails when unified sources are not in use
+        https://bugs.webkit.org/show_bug.cgi?id=198722
+
+        Reviewed by Keith Miller.
+
+        Added missing inclusions of headers in several files which make use of inline functions.
+
+        * b3/B3AtomicValue.cpp:
+        * b3/B3BlockInsertionSet.cpp:
+        * b3/B3FenceValue.cpp:
+        * b3/B3LowerMacrosAfterOptimizations.cpp:
+        * b3/B3PureCSE.cpp:
+        * b3/B3StackmapValue.cpp:
+        * b3/B3SwitchValue.cpp:
+        * b3/B3UseCounts.cpp:
+        * b3/B3VariableValue.cpp:
+        * b3/B3WasmAddressValue.cpp:
+        * b3/B3WasmBoundsCheckValue.cpp:
+        * ftl/FTLCompile.cpp:
+        * wasm/WasmSectionParser.cpp:
+        * wasm/WasmTable.cpp:
+        * wasm/WasmValidate.cpp:
+
 2019-06-10  Keith Miller  <[email protected]>
 
         Make new Symbol/Promise API public

Modified: trunk/Source/_javascript_Core/b3/B3AtomicValue.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3AtomicValue.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3AtomicValue.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -25,6 +25,7 @@
 
 #include "config.h"
 #include "B3AtomicValue.h"
+#include "B3ValueInlines.h"
 
 #if ENABLE(B3_JIT)
 

Modified: trunk/Source/_javascript_Core/b3/B3BlockInsertionSet.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3BlockInsertionSet.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3BlockInsertionSet.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -31,6 +31,7 @@
 #include "B3BasicBlockInlines.h"
 #include "B3InsertionSet.h"
 #include "B3ProcedureInlines.h"
+#include "B3ValueInlines.h"
 #include <wtf/BubbleSort.h>
 
 namespace JSC { namespace B3 {

Modified: trunk/Source/_javascript_Core/b3/B3FenceValue.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3FenceValue.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3FenceValue.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -25,6 +25,7 @@
 
 #include "config.h"
 #include "B3FenceValue.h"
+#include "B3ValueInlines.h"
 
 #if ENABLE(B3_JIT)
 

Modified: trunk/Source/_javascript_Core/b3/B3LowerMacrosAfterOptimizations.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3LowerMacrosAfterOptimizations.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3LowerMacrosAfterOptimizations.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -37,6 +37,7 @@
 #include "B3ConstPtrValue.h"
 #include "B3InsertionSetInlines.h"
 #include "B3PhaseScope.h"
+#include "B3ValueInlines.h"
 
 namespace JSC { namespace B3 {
 

Modified: trunk/Source/_javascript_Core/b3/B3PureCSE.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3PureCSE.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3PureCSE.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -31,6 +31,7 @@
 #include "B3Dominators.h"
 #include "B3PhaseScope.h"
 #include "B3Value.h"
+#include "B3ValueInlines.h"
 
 namespace JSC { namespace B3 {
 

Modified: trunk/Source/_javascript_Core/b3/B3StackmapValue.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3StackmapValue.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3StackmapValue.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -25,6 +25,7 @@
 
 #include "config.h"
 #include "B3StackmapValue.h"
+#include "B3ValueInlines.h"
 
 #if ENABLE(B3_JIT)
 

Modified: trunk/Source/_javascript_Core/b3/B3SwitchValue.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3SwitchValue.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3SwitchValue.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -29,6 +29,7 @@
 #if ENABLE(B3_JIT)
 
 #include "B3BasicBlockInlines.h"
+#include "B3ValueInlines.h"
 #include <wtf/ListDump.h>
 
 namespace JSC { namespace B3 {

Modified: trunk/Source/_javascript_Core/b3/B3UseCounts.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3UseCounts.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3UseCounts.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -29,6 +29,7 @@
 #if ENABLE(B3_JIT)
 
 #include "B3Procedure.h"
+#include "B3ValueInlines.h"
 
 namespace JSC { namespace B3 {
 

Modified: trunk/Source/_javascript_Core/b3/B3VariableValue.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3VariableValue.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3VariableValue.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -28,6 +28,7 @@
 
 #if ENABLE(B3_JIT)
 
+#include "B3ValueInlines.h"
 #include "B3Variable.h"
 
 namespace JSC { namespace B3 {

Modified: trunk/Source/_javascript_Core/b3/B3WasmAddressValue.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3WasmAddressValue.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3WasmAddressValue.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -28,6 +28,8 @@
 
 #if ENABLE(B3_JIT)
 
+#include "B3ValueInlines.h"
+
 namespace JSC { namespace B3 {
 
 WasmAddressValue::~WasmAddressValue()

Modified: trunk/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -29,6 +29,8 @@
 
 #if ENABLE(B3_JIT)
 
+#include "B3ValueInlines.h"
+
 namespace JSC { namespace B3 {
 
 WasmBoundsCheckValue::~WasmBoundsCheckValue()

Modified: trunk/Source/_javascript_Core/ftl/FTLCompile.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -34,6 +34,7 @@
 #include "B3ProcedureInlines.h"
 #include "B3StackSlot.h"
 #include "B3Value.h"
+#include "B3ValueInlines.h"
 #include "CodeBlockWithJITType.h"
 #include "CCallHelpers.h"
 #include "DFGCommon.h"

Modified: trunk/Source/_javascript_Core/wasm/WasmSectionParser.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/wasm/WasmSectionParser.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/wasm/WasmSectionParser.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -30,6 +30,7 @@
 #if ENABLE(WEBASSEMBLY)
 
 #include "IdentifierInlines.h"
+#include "JSCJSValueInlines.h"
 #include "WasmMemoryInformation.h"
 #include "WasmNameSectionParser.h"
 #include "WasmOps.h"

Modified: trunk/Source/_javascript_Core/wasm/WasmTable.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/wasm/WasmTable.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/wasm/WasmTable.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -28,6 +28,7 @@
 
 #if ENABLE(WEBASSEMBLY)
 
+#include "JSCJSValueInlines.h"
 #include <wtf/CheckedArithmetic.h>
 #include <wtf/StdLibExtras.h>
 #include <type_traits>

Modified: trunk/Source/_javascript_Core/wasm/WasmValidate.cpp (246265 => 246266)


--- trunk/Source/_javascript_Core/wasm/WasmValidate.cpp	2019-06-10 16:35:00 UTC (rev 246265)
+++ trunk/Source/_javascript_Core/wasm/WasmValidate.cpp	2019-06-10 17:16:18 UTC (rev 246266)
@@ -28,6 +28,7 @@
 
 #if ENABLE(WEBASSEMBLY)
 
+#include "JSCJSValueInlines.h"
 #include "WasmFunctionParser.h"
 #include <wtf/CommaPrinter.h>
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to