Title: [246267] trunk/Source/WebCore
Revision
246267
Author
[email protected]
Date
2019-06-10 10:41:32 -0700 (Mon, 10 Jun 2019)

Log Message

REGRESSION (r245396): Page load time performance regression
https://bugs.webkit.org/show_bug.cgi?id=198382

Reviewed by Per Arne Vollan.

Use a delay of 2000ms instead of 500ms when scheduling rendering updates
for IntersectionObserver targets added during page load. This is a
speculative fix for a page load time regression caused by r245396 and
still not fixed after r245958.

* dom/Document.cpp:
(WebCore::Document::scheduleTimedRenderingUpdate):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (246266 => 246267)


--- trunk/Source/WebCore/ChangeLog	2019-06-10 17:16:18 UTC (rev 246266)
+++ trunk/Source/WebCore/ChangeLog	2019-06-10 17:41:32 UTC (rev 246267)
@@ -1,3 +1,18 @@
+2019-06-10  Ali Juma  <[email protected]>
+
+        REGRESSION (r245396): Page load time performance regression
+        https://bugs.webkit.org/show_bug.cgi?id=198382
+
+        Reviewed by Per Arne Vollan.
+
+        Use a delay of 2000ms instead of 500ms when scheduling rendering updates
+        for IntersectionObserver targets added during page load. This is a
+        speculative fix for a page load time regression caused by r245396 and
+        still not fixed after r245958.
+
+        * dom/Document.cpp:
+        (WebCore::Document::scheduleTimedRenderingUpdate):
+
 2019-06-10  Sihui Liu  <[email protected]>
 
         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies

Modified: trunk/Source/WebCore/dom/Document.cpp (246266 => 246267)


--- trunk/Source/WebCore/dom/Document.cpp	2019-06-10 17:16:18 UTC (rev 246266)
+++ trunk/Source/WebCore/dom/Document.cpp	2019-06-10 17:41:32 UTC (rev 246267)
@@ -353,7 +353,7 @@
 };
 
 #if ENABLE(INTERSECTION_OBSERVER)
-static const Seconds intersectionObserversInitialUpdateDelay { 500_ms };
+static const Seconds intersectionObserversInitialUpdateDelay { 2000_ms };
 #endif
 
 // DOM Level 2 says (letters added):
@@ -7294,6 +7294,9 @@
 
 void Document::scheduleTimedRenderingUpdate()
 {
+#if ENABLE(INTERSECTION_OBSERVER)
+    m_intersectionObserversInitialUpdateTimer.stop();
+#endif
     if (auto page = this->page())
         page->renderingUpdateScheduler().scheduleTimedRenderingUpdate();
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to