Title: [246584] trunk/LayoutTests
Revision
246584
Author
[email protected]
Date
2019-06-19 03:54:13 -0700 (Wed, 19 Jun 2019)

Log Message

resize-observer/element-leak.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=198666

Patch by Cathie Chen <[email protected]> on 2019-06-19
Reviewed by Frédéric Wang.

It takes a very long time to construct iframes which create and remove 1000 elements. This would cause timeout sometimes.
In order to make it more effective, reduce the number of elements to 200 and put them into a container first,
then attach the container to DOM tree.

* resize-observer/resources/element-leak-frame.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (246583 => 246584)


--- trunk/LayoutTests/ChangeLog	2019-06-19 09:43:57 UTC (rev 246583)
+++ trunk/LayoutTests/ChangeLog	2019-06-19 10:54:13 UTC (rev 246584)
@@ -1,3 +1,16 @@
+2019-06-19  Cathie Chen  <[email protected]>
+
+        resize-observer/element-leak.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=198666
+
+        Reviewed by Frédéric Wang.
+
+        It takes a very long time to construct iframes which create and remove 1000 elements. This would cause timeout sometimes.
+        In order to make it more effective, reduce the number of elements to 200 and put them into a container first,
+        then attach the container to DOM tree.
+
+        * resize-observer/resources/element-leak-frame.html:
+
 2019-06-18  Megan Gardner  <[email protected]>
 
         Text Selection gesture has changed behavior, change test to match new behavior

Modified: trunk/LayoutTests/resize-observer/resources/element-leak-frame.html (246583 => 246584)


--- trunk/LayoutTests/resize-observer/resources/element-leak-frame.html	2019-06-19 09:43:57 UTC (rev 246583)
+++ trunk/LayoutTests/resize-observer/resources/element-leak-frame.html	2019-06-19 10:54:13 UTC (rev 246584)
@@ -3,7 +3,7 @@
 <script src=""
 <script type="text/_javascript_">
 
-const targetCount = 1000;
+const targetCount = 200;
 var resizeObserver = new ResizeObserver( entries => {
     for (let entry of entries)
         entry.target.myEntry = entry;
@@ -15,10 +15,12 @@
     parent.postMessage('Notified', '*');
 });
 
+var container = document.createElement('div');
 for (let i = 0; i < targetCount; ++i) {
     var target = document.createElement('div');
-    document.body.appendChild(target);
+    container.appendChild(target);
 }
+document.body.appendChild(container);
 
 document.querySelectorAll('div').forEach(target => resizeObserver.observe(target));
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to