Title: [246587] trunk/Source/_javascript_Core
- Revision
- 246587
- Author
- [email protected]
- Date
- 2019-06-19 08:07:31 -0700 (Wed, 19 Jun 2019)
Log Message
[CMake][Win] CombinedDomains.json is generated twice in _javascript_Core_CopyPrivateHeaders and _javascript_Core projects
https://bugs.webkit.org/show_bug.cgi?id=198853
Reviewed by Don Olmstead.
_javascript_Core_CopyPrivateHeaders target needs to have a direct or
indirect dependency of _javascript_Core target for CMake Visual
Studio generator to eliminate duplicated custom commands.
* CMakeLists.txt: Added _javascript_Core as a dependency of _javascript_Core_CopyPrivateHeaders.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (246586 => 246587)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2019-06-19 12:03:15 UTC (rev 246586)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2019-06-19 15:07:31 UTC (rev 246587)
@@ -1297,6 +1297,11 @@
FILES ${_javascript_Core_PRIVATE_FRAMEWORK_HEADERS}
FLATTENED
)
+# _javascript_Core_CopyPrivateHeaders needs to have a direct or indirect
+# dependency of _javascript_Core for CMake Visual Studio generator to
+# eliminate duplicated custom commands. Otherwise,
+# CombinedDomains.json will be generated in both projects.
+add_dependencies(_javascript_Core_CopyPrivateHeaders _javascript_Core)
target_include_directories(LLIntSettingsExtractor PRIVATE
${_javascript_Core_INCLUDE_DIRECTORIES}
Modified: trunk/Source/_javascript_Core/ChangeLog (246586 => 246587)
--- trunk/Source/_javascript_Core/ChangeLog 2019-06-19 12:03:15 UTC (rev 246586)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-06-19 15:07:31 UTC (rev 246587)
@@ -1,3 +1,16 @@
+2019-06-19 Fujii Hironori <[email protected]>
+
+ [CMake][Win] CombinedDomains.json is generated twice in _javascript_Core_CopyPrivateHeaders and _javascript_Core projects
+ https://bugs.webkit.org/show_bug.cgi?id=198853
+
+ Reviewed by Don Olmstead.
+
+ _javascript_Core_CopyPrivateHeaders target needs to have a direct or
+ indirect dependency of _javascript_Core target for CMake Visual
+ Studio generator to eliminate duplicated custom commands.
+
+ * CMakeLists.txt: Added _javascript_Core as a dependency of _javascript_Core_CopyPrivateHeaders.
+
2019-06-18 Yusuke Suzuki <[email protected]>
[JSC] JSLock should be WebThread aware
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
