Title: [246984] releases/WebKitGTK/webkit-2.24
- Revision
- 246984
- Author
- [email protected]
- Date
- 2019-07-01 02:21:59 -0700 (Mon, 01 Jul 2019)
Log Message
Merge r245848 - [MSE][GStreamer] update the readyState correctly in MediaPlayerPrivateGStreamerMSE
https://bugs.webkit.org/show_bug.cgi?id=197834
Patch by Yacine Bandou <[email protected]> on 2019-05-28
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
The buffering state and the m_downloadFinished boolean aren't supported in the MSE case.
When the readyState is already "HaveEnoughData", we don't want to revert it to "HaveFutureData",
or else the MediaPlayer would send a "canplay" event instead of a "canplaythrough".
Test: media/media-source/media-source-canplaythrough-event.html
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):
LayoutTests:
Add a new test that checks if the MediaElement receives the "canplaythrough"
event when the media content is entirely injected to MSE sourceBuffer.
* media/media-source/media-source-canplaythrough-event-expected.txt: Added.
* media/media-source/media-source-canplaythrough-event.html: Added.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog (246983 => 246984)
--- releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog 2019-07-01 09:21:56 UTC (rev 246983)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog 2019-07-01 09:21:59 UTC (rev 246984)
@@ -1,3 +1,16 @@
+2019-05-28 Yacine Bandou <[email protected]>
+
+ [MSE][GStreamer] update the readyState correctly in MediaPlayerPrivateGStreamerMSE
+ https://bugs.webkit.org/show_bug.cgi?id=197834
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Add a new test that checks if the MediaElement receives the "canplaythrough"
+ event when the media content is entirely injected to MSE sourceBuffer.
+
+ * media/media-source/media-source-canplaythrough-event-expected.txt: Added.
+ * media/media-source/media-source-canplaythrough-event.html: Added.
+
2019-06-12 Carlos Garcia Campos <[email protected]>
[cairo][SVG] Putting multiple path elements in clippath causes rendering artifacts
Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (246983 => 246984)
--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-07-01 09:21:56 UTC (rev 246983)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-07-01 09:21:59 UTC (rev 246984)
@@ -1,3 +1,19 @@
+2019-05-28 Yacine Bandou <[email protected]>
+
+ [MSE][GStreamer] update the readyState correctly in MediaPlayerPrivateGStreamerMSE
+ https://bugs.webkit.org/show_bug.cgi?id=197834
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ The buffering state and the m_downloadFinished boolean aren't supported in the MSE case.
+ When the readyState is already "HaveEnoughData", we don't want to revert it to "HaveFutureData",
+ or else the MediaPlayer would send a "canplay" event instead of a "canplaythrough".
+
+ Test: media/media-source/media-source-canplaythrough-event.html
+
+ * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
+ (WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):
+
2019-06-14 Carlos Garcia Campos <[email protected]>
[cairo] Entering text into forms on github.com creates a trapezoid artifact
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes