Title: [246985] releases/WebKitGTK/webkit-2.24/Source/WebCore
Revision
246985
Author
[email protected]
Date
2019-07-01 02:22:03 -0700 (Mon, 01 Jul 2019)

Log Message

Merge r246192 - [GStreamer] videorate issues with v4l2src
https://bugs.webkit.org/show_bug.cgi?id=198614

Reviewed by Xabier Rodriguez-Calvar.

Configure videorate to cope with the live stream provided by the
source element. Not doing so might lead to errors in the v4l2
buffer allocator.

* platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createConverter):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (246984 => 246985)


--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-07-01 09:21:59 UTC (rev 246984)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-07-01 09:22:03 UTC (rev 246985)
@@ -1,3 +1,17 @@
+2019-06-07  Philippe Normand  <[email protected]>
+
+        [GStreamer] videorate issues with v4l2src
+        https://bugs.webkit.org/show_bug.cgi?id=198614
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Configure videorate to cope with the live stream provided by the
+        source element. Not doing so might lead to errors in the v4l2
+        buffer allocator.
+
+        * platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
+        (WebCore::GStreamerVideoCapturer::createConverter):
+
 2019-05-28  Yacine Bandou  <[email protected]>
 
         [MSE][GStreamer] update the readyState correctly in MediaPlayerPrivateGStreamerMSE

Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp (246984 => 246985)


--- releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp	2019-07-01 09:21:59 UTC (rev 246984)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp	2019-07-01 09:22:03 UTC (rev 246985)
@@ -38,8 +38,8 @@
 
 GstElement* GStreamerVideoCapturer::createConverter()
 {
-    auto converter = gst_parse_bin_from_description("videoscale ! videoconvert ! videorate", TRUE, nullptr);
-
+    // https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/97#note_56575
+    auto converter = gst_parse_bin_from_description("videoscale ! videoconvert ! videorate drop-_only_=1 average-period=1", TRUE, nullptr);
     ASSERT(converter);
 
     return converter;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to