Title: [247028] trunk/Source/WebKit
Revision
247028
Author
[email protected]
Date
2019-07-01 15:16:11 -0700 (Mon, 01 Jul 2019)

Log Message

StorageManager::SessionStorageNamespace::allowedConnections() should not copy the HashSet
https://bugs.webkit.org/show_bug.cgi?id=199379

Reviewed by Alex Christensen.

This was pretty inefficient.

* NetworkProcess/WebStorage/StorageManager.cpp:
(WebKit::StorageManager::SessionStorageNamespace::allowedConnections const):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (247027 => 247028)


--- trunk/Source/WebKit/ChangeLog	2019-07-01 22:10:44 UTC (rev 247027)
+++ trunk/Source/WebKit/ChangeLog	2019-07-01 22:16:11 UTC (rev 247028)
@@ -1,3 +1,15 @@
+2019-07-01  Chris Dumez  <[email protected]>
+
+        StorageManager::SessionStorageNamespace::allowedConnections() should not copy the HashSet
+        https://bugs.webkit.org/show_bug.cgi?id=199379
+
+        Reviewed by Alex Christensen.
+
+        This was pretty inefficient.
+
+        * NetworkProcess/WebStorage/StorageManager.cpp:
+        (WebKit::StorageManager::SessionStorageNamespace::allowedConnections const):
+
 2019-07-01  Wenson Hsieh  <[email protected]>
 
         [iOS] REGRESSION (r246757): Unable to select non-editable text in subframes

Modified: trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp (247027 => 247028)


--- trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp	2019-07-01 22:10:44 UTC (rev 247027)
+++ trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp	2019-07-01 22:16:11 UTC (rev 247028)
@@ -399,7 +399,7 @@
 
     bool isEmpty() const { return m_storageAreaMap.isEmpty(); }
 
-    HashSet<IPC::Connection::UniqueID> allowedConnections() const { return m_allowedConnections; }
+    const HashSet<IPC::Connection::UniqueID>& allowedConnections() const { return m_allowedConnections; }
     void addAllowedConnection(IPC::Connection::UniqueID);
     void removeAllowedConnection(IPC::Connection::UniqueID);
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to