Title: [247029] trunk/Source/WebKit
- Revision
- 247029
- Author
- [email protected]
- Date
- 2019-07-01 15:27:07 -0700 (Mon, 01 Jul 2019)
Log Message
Remove virtual functions on WebProcessLifetimeObserver that are unused after r245540
https://bugs.webkit.org/show_bug.cgi?id=199383
Reviewed by Alex Christensen.
* UIProcess/WebProcessLifetimeObserver.h:
(WebKit::WebProcessLifetimeObserver::webProcessDidCloseConnection):
* UIProcess/WebProcessLifetimeTracker.cpp:
(WebKit::WebProcessLifetimeTracker::addObserver):
(WebKit::WebProcessLifetimeTracker::pageWasInvalidated):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (247028 => 247029)
--- trunk/Source/WebKit/ChangeLog 2019-07-01 22:16:11 UTC (rev 247028)
+++ trunk/Source/WebKit/ChangeLog 2019-07-01 22:27:07 UTC (rev 247029)
@@ -1,5 +1,18 @@
2019-07-01 Chris Dumez <[email protected]>
+ Remove virtual functions on WebProcessLifetimeObserver that are unused after r245540
+ https://bugs.webkit.org/show_bug.cgi?id=199383
+
+ Reviewed by Alex Christensen.
+
+ * UIProcess/WebProcessLifetimeObserver.h:
+ (WebKit::WebProcessLifetimeObserver::webProcessDidCloseConnection):
+ * UIProcess/WebProcessLifetimeTracker.cpp:
+ (WebKit::WebProcessLifetimeTracker::addObserver):
+ (WebKit::WebProcessLifetimeTracker::pageWasInvalidated):
+
+2019-07-01 Chris Dumez <[email protected]>
+
StorageManager::SessionStorageNamespace::allowedConnections() should not copy the HashSet
https://bugs.webkit.org/show_bug.cgi?id=199379
Modified: trunk/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h (247028 => 247029)
--- trunk/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h 2019-07-01 22:16:11 UTC (rev 247028)
+++ trunk/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h 2019-07-01 22:27:07 UTC (rev 247029)
@@ -53,12 +53,10 @@
private:
friend class WebProcessLifetimeTracker;
- virtual void webPageWasAdded(WebPageProxy&) { }
virtual void webProcessWillOpenConnection(WebProcessProxy&, IPC::Connection&) { }
virtual void webPageWillOpenConnection(WebPageProxy&, IPC::Connection&) { }
virtual void webPageDidCloseConnection(WebPageProxy&, IPC::Connection&) { }
virtual void webProcessDidCloseConnection(WebProcessProxy&, IPC::Connection&) { }
- virtual void webPageWasInvalidated(WebPageProxy&) { }
HashCountedSet<WebProcessProxy*> m_processes;
};
Modified: trunk/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp (247028 => 247029)
--- trunk/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp 2019-07-01 22:16:11 UTC (rev 247028)
+++ trunk/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp 2019-07-01 22:27:07 UTC (rev 247029)
@@ -47,8 +47,6 @@
m_observers.add(&observer);
- observer.webPageWasAdded(m_webPageProxy);
-
if (processIsRunning(m_webPageProxy.process()))
observer.addWebPage(m_webPageProxy, m_webPageProxy.process());
}
@@ -74,11 +72,8 @@
if (!processIsRunning(m_webPageProxy.process()))
return;
- for (auto& observer : m_observers) {
+ for (auto& observer : m_observers)
observer->removeWebPage(m_webPageProxy, m_webPageProxy.process());
-
- observer->webPageWasInvalidated(m_webPageProxy);
- }
}
bool WebProcessLifetimeTracker::processIsRunning(WebProcessProxy& process)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
