Title: [248085] trunk/Source/WebKit
- Revision
- 248085
- Author
- [email protected]
- Date
- 2019-07-31 17:12:18 -0700 (Wed, 31 Jul 2019)
Log Message
WKImagePreviewViewController not being autoreleased
https://bugs.webkit.org/show_bug.cgi?id=200325
<rdar://problem/53788214>
Reviewed by Wenson Hsieh.
Wenson noticed I wasn't autoreleasing the WKImagePreviewViewController.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView continueContextMenuInteraction:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (248084 => 248085)
--- trunk/Source/WebKit/ChangeLog 2019-08-01 00:11:35 UTC (rev 248084)
+++ trunk/Source/WebKit/ChangeLog 2019-08-01 00:12:18 UTC (rev 248085)
@@ -1,3 +1,16 @@
+2019-07-31 Dean Jackson <[email protected]>
+
+ WKImagePreviewViewController not being autoreleased
+ https://bugs.webkit.org/show_bug.cgi?id=200325
+ <rdar://problem/53788214>
+
+ Reviewed by Wenson Hsieh.
+
+ Wenson noticed I wasn't autoreleasing the WKImagePreviewViewController.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView continueContextMenuInteraction:]):
+
2019-07-31 Chris Dumez <[email protected]>
REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (248084 => 248085)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-08-01 00:11:35 UTC (rev 248084)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-08-01 00:12:18 UTC (rev 248085)
@@ -7993,7 +7993,7 @@
if (!strongSelf)
return nil;
- return [[WKImagePreviewViewController alloc] initWithCGImage:cgImage defaultActions:nil elementInfo:elementInfo.get()];
+ return [[[WKImagePreviewViewController alloc] initWithCGImage:cgImage defaultActions:nil elementInfo:elementInfo.get()] autorelease];
};
return continueWithContextMenuConfiguration([UIContextMenuConfiguration configurationWithIdentifier:nil previewProvider:contentPreviewProvider actionProvider:actionMenuProvider]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
