Title: [248086] branches/safari-608-branch/Source/WebKit
- Revision
- 248086
- Author
- [email protected]
- Date
- 2019-07-31 17:18:58 -0700 (Wed, 31 Jul 2019)
Log Message
Cherry-pick r247700. rdar://problem/53456055
WebKit SPI fix for [ClickyOrb] Audio continues playing after dismissing a video preview in Safari
https://bugs.webkit.org/show_bug.cgi?id=200011
<rdar://problem/53409457>
Reviewed by Tim Horton.
Don't check for the SPI @selector(_webView:contextMenuDidEndForElement:)
on the WKUIDelegate so that clients that got caught implementing the
SPI before moving to the real API can still clean-up state. In other words,
don't force a client that only implements that method to move completely
to the new API.
* UIProcess/ios/WKContentViewInteraction.mm:
(needsDeprecatedPreviewAPI):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (248085 => 248086)
--- branches/safari-608-branch/Source/WebKit/ChangeLog 2019-08-01 00:12:18 UTC (rev 248085)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog 2019-08-01 00:18:58 UTC (rev 248086)
@@ -1,5 +1,43 @@
2019-07-31 Alan Coon <[email protected]>
+ Cherry-pick r247700. rdar://problem/53456055
+
+ WebKit SPI fix for [ClickyOrb] Audio continues playing after dismissing a video preview in Safari
+ https://bugs.webkit.org/show_bug.cgi?id=200011
+ <rdar://problem/53409457>
+
+ Reviewed by Tim Horton.
+
+ Don't check for the SPI @selector(_webView:contextMenuDidEndForElement:)
+ on the WKUIDelegate so that clients that got caught implementing the
+ SPI before moving to the real API can still clean-up state. In other words,
+ don't force a client that only implements that method to move completely
+ to the new API.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (needsDeprecatedPreviewAPI):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-07-22 Dean Jackson <[email protected]>
+
+ WebKit SPI fix for [ClickyOrb] Audio continues playing after dismissing a video preview in Safari
+ https://bugs.webkit.org/show_bug.cgi?id=200011
+ <rdar://problem/53409457>
+
+ Reviewed by Tim Horton.
+
+ Don't check for the SPI @selector(_webView:contextMenuDidEndForElement:)
+ on the WKUIDelegate so that clients that got caught implementing the
+ SPI before moving to the real API can still clean-up state. In other words,
+ don't force a client that only implements that method to move completely
+ to the new API.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (needsDeprecatedPreviewAPI):
+
+2019-07-31 Alan Coon <[email protected]>
+
Cherry-pick r248038. rdar://problem/53764075
AX: com.apple.WebKit.WebContent at com.apple.WebKit: -[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]
Modified: branches/safari-608-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (248085 => 248086)
--- branches/safari-608-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-08-01 00:12:18 UTC (rev 248085)
+++ branches/safari-608-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-08-01 00:18:58 UTC (rev 248086)
@@ -7650,6 +7650,9 @@
static bool needsDeprecatedPreviewAPI(id<WKUIDelegate> delegate)
{
// FIXME: Replace these with booleans in UIDelegate.h.
+ // Note that we explicitly do not test for @selector(_webView:contextMenuDidEndForElement:) since
+ // that's used by MobileSafari to clean up state even though they haven't moved to the new API.
+
return delegate
&& ![delegate respondsToSelector:@selector(_webView:contextMenuConfigurationForElement:completionHandler:)]
&& ![delegate respondsToSelector:@selector(webView:contextMenuConfigurationForElement:completionHandler:)]
@@ -7657,7 +7660,6 @@
&& ![delegate respondsToSelector:@selector(webView:contextMenuForElement:willCommitWithAnimator:)]
&& ![delegate respondsToSelector:@selector(_webView:contextMenuWillPresentForElement:)]
&& ![delegate respondsToSelector:@selector(webView:contextMenuWillPresentForElement:)]
- && ![delegate respondsToSelector:@selector(_webView:contextMenuDidEndForElement:)]
&& ![delegate respondsToSelector:@selector(webView:contextMenuDidEndForElement:)]
&& ([delegate respondsToSelector:@selector(webView:shouldPreviewElement:)]
|| [delegate respondsToSelector:@selector(webView:previewingViewControllerForElement:defaultActions:)]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
