Title: [248242] releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog
- Revision
- 248242
- Author
- [email protected]
- Date
- 2019-08-03 20:23:36 -0700 (Sat, 03 Aug 2019)
Log Message
Merge r246808 - Add didBecomePrototype() calls to global context prototypes
https://bugs.webkit.org/show_bug.cgi?id=199202
Reviewed by Mark Lam.
This fixes some crashes related to asserting that all prototypes
have been marked as such in JSC from
https://trac.webkit.org/changeset/246801. It's ok to call
didBecomePrototype here as we setting up the world state right now
so we won't be having a bad time.
We don't automatically call didBecomePrototype() for
setPrototypeWithoutTransition because existing objects may already
have this structure so it seems more reasonable to be explicit
there.
* bindings/js/JSWindowProxy.cpp:
(WebCore::JSWindowProxy::setWindow):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* worklets/WorkletScriptController.cpp:
(WebCore::WorkletScriptController::initScriptWithSubclass):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (248241 => 248242)
--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-08-04 03:23:34 UTC (rev 248241)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-08-04 03:23:36 UTC (rev 248242)
@@ -23,6 +23,31 @@
* worklets/WorkletScriptController.cpp:
(WebCore::WorkletScriptController::initScriptWithSubclass):
+2019-06-25 Keith Miller <[email protected]>
+
+ Add didBecomePrototype() calls to global context prototypes
+ https://bugs.webkit.org/show_bug.cgi?id=199202
+
+ Reviewed by Mark Lam.
+
+ This fixes some crashes related to asserting that all prototypes
+ have been marked as such in JSC from
+ https://trac.webkit.org/changeset/246801. It's ok to call
+ didBecomePrototype here as we setting up the world state right now
+ so we won't be having a bad time.
+
+ We don't automatically call didBecomePrototype() for
+ setPrototypeWithoutTransition because existing objects may already
+ have this structure so it seems more reasonable to be explicit
+ there.
+
+ * bindings/js/JSWindowProxy.cpp:
+ (WebCore::JSWindowProxy::setWindow):
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::initScript):
+ * worklets/WorkletScriptController.cpp:
+ (WebCore::WorkletScriptController::initScriptWithSubclass):
+
2019-05-20 Chris Dumez <[email protected]>
Fix security check in ScriptController::canAccessFromCurrentOrigin()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
