Title: [248255] releases/WebKitGTK/webkit-2.24/Source/WebCore
Revision
248255
Author
[email protected]
Date
2019-08-03 20:24:10 -0700 (Sat, 03 Aug 2019)

Log Message

Merge r247643 - [GStreamer] Flush get_range calls during PAUSED->READY in WebKitWebSource
https://bugs.webkit.org/show_bug.cgi?id=199934

Reviewed by Xabier Rodriguez-Calvar.

Unit testing not applicable.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcChangeState): A well-behaved element should unblock streaming threads
during a PAUSED->READY transition, so do that here.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (248254 => 248255)


--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-08-04 03:24:08 UTC (rev 248254)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-08-04 03:24:10 UTC (rev 248255)
@@ -1,3 +1,16 @@
+2019-07-19  Charlie Turner  <[email protected]>
+
+        [GStreamer] Flush get_range calls during PAUSED->READY in WebKitWebSource
+        https://bugs.webkit.org/show_bug.cgi?id=199934
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Unit testing not applicable.
+
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (webKitWebSrcChangeState): A well-behaved element should unblock streaming threads
+        during a PAUSED->READY transition, so do that here.
+
 2019-07-15  Michael Catanzaro  <[email protected]>
 
         [GTK] GitHub breaks on FreeBSD because of "unsupported browser"

Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (248254 => 248255)


--- releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2019-08-04 03:24:08 UTC (rev 248254)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2019-08-04 03:24:10 UTC (rev 248255)
@@ -776,8 +776,14 @@
     case GST_STATE_CHANGE_READY_TO_NULL:
         webKitWebSrcCloseSession(src);
         break;
-    default:
+    case GST_STATE_CHANGE_PAUSED_TO_READY: {
+        LockHolder locker(src->priv->responseLock);
+        GST_DEBUG_OBJECT(src, "PAUSED->READY cancelling network requests");
+        src->priv->isFlushing = true;
+        src->priv->responseCondition.notifyOne();
         break;
+    } default:
+        break;
     }
 
     return GST_ELEMENT_CLASS(parent_class)->change_state(element, transition);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to