Title: [248587] trunk/Source/WebInspectorUI
- Revision
- 248587
- Author
- [email protected]
- Date
- 2019-08-12 20:50:40 -0700 (Mon, 12 Aug 2019)
Log Message
Web Inspector: REGRESSION: DOMDebugger: breakpoints are forcibly enabled when resolving DOM breakpoints for newly added nodes
https://bugs.webkit.org/show_bug.cgi?id=200639
Reviewed by Joseph Pecoraro.
Since DOM breakpoints revolve around a given DOM node, we attempt to restore DOM breakpoints
whenever new nodes are added by matching them to the path of the DOM breakpoint. When doing
so, we should be in a "temporarily restoring breakpoints" mode so that we don't forcibly
enable all breakpoints.
* UserInterface/Controllers/DOMDebuggerManager.js:
(WI.DOMDebuggerManager.prototype._speculativelyResolveDOMBreakpointsForURL):
(WI.DOMDebuggerManager.prototype._nodeInserted):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (248586 => 248587)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-08-13 03:01:11 UTC (rev 248586)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-08-13 03:50:40 UTC (rev 248587)
@@ -1,5 +1,21 @@
2019-08-12 Devin Rousso <[email protected]>
+ Web Inspector: REGRESSION: DOMDebugger: breakpoints are forcibly enabled when resolving DOM breakpoints for newly added nodes
+ https://bugs.webkit.org/show_bug.cgi?id=200639
+
+ Reviewed by Joseph Pecoraro.
+
+ Since DOM breakpoints revolve around a given DOM node, we attempt to restore DOM breakpoints
+ whenever new nodes are added by matching them to the path of the DOM breakpoint. When doing
+ so, we should be in a "temporarily restoring breakpoints" mode so that we don't forcibly
+ enable all breakpoints.
+
+ * UserInterface/Controllers/DOMDebuggerManager.js:
+ (WI.DOMDebuggerManager.prototype._speculativelyResolveDOMBreakpointsForURL):
+ (WI.DOMDebuggerManager.prototype._nodeInserted):
+
+2019-08-12 Devin Rousso <[email protected]>
+
Web Inspector: Elements: Styles: add space between media query and style icon
https://bugs.webkit.org/show_bug.cgi?id=200623
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js (248586 => 248587)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js 2019-08-13 03:01:11 UTC (rev 248586)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js 2019-08-13 03:50:40 UTC (rev 248587)
@@ -561,8 +561,12 @@
return;
}
- if (nodeIdentifier)
- this._resolveDOMBreakpoint(breakpoint, nodeIdentifier);
+ if (!nodeIdentifier)
+ return;
+
+ this._restoringBreakpoints = true;
+ this._resolveDOMBreakpoint(breakpoint, nodeIdentifier);
+ this._restoringBreakpoints = false;
});
}
}
@@ -826,7 +830,9 @@
if (breakpoint.path !== node.path())
continue;
+ this._restoringBreakpoints = true;
this._resolveDOMBreakpoint(breakpoint, node.id);
+ this._restoringBreakpoints = false;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
