Title: [248588] trunk/Source/WebInspectorUI
- Revision
- 248588
- Author
- [email protected]
- Date
- 2019-08-12 20:52:38 -0700 (Mon, 12 Aug 2019)
Log Message
Web Inspector: REGRESSION(r248201): DOMDebugger: unable to add event breakpoint when All Events breakpoint is enabled
https://bugs.webkit.org/show_bug.cgi?id=200561
Reviewed by Joseph Pecoraro.
* UserInterface/Controllers/DOMDebuggerManager.js:
(WI.DOMDebuggerManager.prototype.addEventBreakpoint):
(WI.DOMDebuggerManager.prototype.removeEventBreakpoint):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (248587 => 248588)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-08-13 03:50:40 UTC (rev 248587)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-08-13 03:52:38 UTC (rev 248588)
@@ -1,5 +1,16 @@
2019-08-12 Devin Rousso <[email protected]>
+ Web Inspector: REGRESSION(r248201): DOMDebugger: unable to add event breakpoint when All Events breakpoint is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=200561
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Controllers/DOMDebuggerManager.js:
+ (WI.DOMDebuggerManager.prototype.addEventBreakpoint):
+ (WI.DOMDebuggerManager.prototype.removeEventBreakpoint):
+
+2019-08-12 Devin Rousso <[email protected]>
+
Web Inspector: REGRESSION: DOMDebugger: breakpoints are forcibly enabled when resolving DOM breakpoints for newly added nodes
https://bugs.webkit.org/show_bug.cgi?id=200639
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js (248587 => 248588)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js 2019-08-13 03:50:40 UTC (rev 248587)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js 2019-08-13 03:52:38 UTC (rev 248588)
@@ -368,7 +368,7 @@
addEventBreakpoint(breakpoint)
{
- console.assert(breakpoint instanceof WI.EventBreakpoint);
+ console.assert(breakpoint instanceof WI.EventBreakpoint, breakpoint);
if (!breakpoint)
return;
@@ -377,9 +377,10 @@
return;
}
- console.assert(breakpoint.type === WI.EventBreakpoint.Type.Listener);
+ console.assert(breakpoint.type === WI.EventBreakpoint.Type.Listener, breakpoint);
+ console.assert(breakpoint.eventName, breakpoint);
- if (this.listenerBreakpointForEventName(breakpoint.eventName))
+ if (this._listenerBreakpoints.find((existing) => existing.eventName === breakpoint.eventName))
return;
this._listenerBreakpoints.push(breakpoint);
@@ -397,7 +398,7 @@
removeEventBreakpoint(breakpoint)
{
- console.assert(breakpoint instanceof WI.EventBreakpoint);
+ console.assert(breakpoint instanceof WI.EventBreakpoint, breakpoint);
if (!breakpoint)
return;
@@ -407,8 +408,10 @@
return;
}
- console.assert(breakpoint.type === WI.EventBreakpoint.Type.Listener);
+ console.assert(breakpoint.type === WI.EventBreakpoint.Type.Listener, breakpoint);
+ console.assert(breakpoint.eventName, breakpoint);
+ console.assert(this._listenerBreakpoints.includes(breakpoint), breakpoint);
if (!this._listenerBreakpoints.includes(breakpoint))
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
