Title: [249028] trunk/LayoutTests
- Revision
- 249028
- Author
- [email protected]
- Date
- 2019-08-22 14:30:46 -0700 (Thu, 22 Aug 2019)
Log Message
REGRESSION (r248974): fast/events/ios/select-all-with-existing-selection.html fails
https://bugs.webkit.org/show_bug.cgi?id=201050
Reviewed by Wenson Hsieh.
* fast/events/ios/select-all-with-existing-selection.html:
The test as-written doesn't actually wait for the tap to complete before
continuing on with the test - it starts immediately when the focus event
fires. This results in the selection being changed by the single click
handler *after* focusing the field.
Rewrite the test to await completion of the tap before moving forward
instead of waiting for focus.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (249027 => 249028)
--- trunk/LayoutTests/ChangeLog 2019-08-22 21:28:29 UTC (rev 249027)
+++ trunk/LayoutTests/ChangeLog 2019-08-22 21:30:46 UTC (rev 249028)
@@ -1,3 +1,19 @@
+2019-08-22 Tim Horton <[email protected]>
+
+ REGRESSION (r248974): fast/events/ios/select-all-with-existing-selection.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=201050
+
+ Reviewed by Wenson Hsieh.
+
+ * fast/events/ios/select-all-with-existing-selection.html:
+ The test as-written doesn't actually wait for the tap to complete before
+ continuing on with the test - it starts immediately when the focus event
+ fires. This results in the selection being changed by the single click
+ handler *after* focusing the field.
+
+ Rewrite the test to await completion of the tap before moving forward
+ instead of waiting for focus.
+
2019-08-22 Said Abou-Hallawa <[email protected]>
Crash may happen when an SVG <feImage> element references the root <svg> element
Modified: trunk/LayoutTests/fast/events/ios/select-all-with-existing-selection.html (249027 => 249028)
--- trunk/LayoutTests/fast/events/ios/select-all-with-existing-selection.html 2019-08-22 21:28:29 UTC (rev 249027)
+++ trunk/LayoutTests/fast/events/ios/select-all-with-existing-selection.html 2019-08-22 21:30:46 UTC (rev 249028)
@@ -26,20 +26,18 @@
UIHelper.keyDown("a", ["metaKey"]);
}
-function runTest()
+async function runTest()
{
let testElement = document.getElementById("test");
console.assert(testElement.value.indexOf("word") !== -1);
- function handleFocus() {
- document.addEventListener("selectionchange", testSelectAll, { once: true });
- testElement.setSelectionRange(testElement.value.indexOf("word"), testElement.value.length);
- }
- testElement.addEventListener("focus", handleFocus, { once: true });
if (window.testRunner)
- UIHelper.activateElement(testElement);
+ await UIHelper.activateElement(testElement);
else
testElement.focus();
+
+ document.addEventListener("selectionchange", testSelectAll, { once: true });
+ testElement.setSelectionRange(testElement.value.indexOf("word"), testElement.value.length);
}
description("This tests that pressing Command + A selects all the text even when there is an existing range selction. To run this test by hand, press Command + A.");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
