Title: [249029] trunk/Source/WebKit
- Revision
- 249029
- Author
- [email protected]
- Date
- 2019-08-22 14:43:53 -0700 (Thu, 22 Aug 2019)
Log Message
Remove logging that contains a URL
https://bugs.webkit.org/show_bug.cgi?id=201052
<rdar://problem/54613204>
Reviewed by Chris Dumez.
checkURLReceivedFromWebProcess in WebProcessProxy.cpp contains an old
logging line that logs a URL. We don't log URLs any more for privacy
reasons, so remove this.
A search for WTFLogAlways.*url turns up other matches, but those are
either false positives or cases where the URLs are logged only on
demand by the developer as part of debugging.
checkURLReceivedFromWebProcess is the only place where a URL is logged
as a matter of course.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (249028 => 249029)
--- trunk/Source/WebKit/ChangeLog 2019-08-22 21:30:46 UTC (rev 249028)
+++ trunk/Source/WebKit/ChangeLog 2019-08-22 21:43:53 UTC (rev 249029)
@@ -1,3 +1,24 @@
+2019-08-22 Keith Rollin <[email protected]>
+
+ Remove logging that contains a URL
+ https://bugs.webkit.org/show_bug.cgi?id=201052
+ <rdar://problem/54613204>
+
+ Reviewed by Chris Dumez.
+
+ checkURLReceivedFromWebProcess in WebProcessProxy.cpp contains an old
+ logging line that logs a URL. We don't log URLs any more for privacy
+ reasons, so remove this.
+
+ A search for WTFLogAlways.*url turns up other matches, but those are
+ either false positives or cases where the URLs are logged only on
+ demand by the developer as part of debugging.
+ checkURLReceivedFromWebProcess is the only place where a URL is logged
+ as a matter of course.
+
+ * UIProcess/WebProcessProxy.cpp:
+ (WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
+
2019-08-22 Adrian Perez de Castro <[email protected]>
[GTK][WPE] Fixes for non-unified builds after r248547
Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (249028 => 249029)
--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp 2019-08-22 21:30:46 UTC (rev 249028)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp 2019-08-22 21:43:53 UTC (rev 249029)
@@ -558,7 +558,7 @@
}
// A Web process that was never asked to load a file URL should not ever ask us to do anything with a file URL.
- WTFLogAlways("Received an unexpected URL from the web process: '%s'\n", url.string().utf8().data());
+ RELEASE_LOG_ERROR(Loading, "Received an unexpected URL from the web process");
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
