Title: [249042] trunk/LayoutTests
- Revision
- 249042
- Author
- [email protected]
- Date
- 2019-08-23 00:25:00 -0700 (Fri, 23 Aug 2019)
Log Message
Revert delete-in-input-in-iframe.html and typing-in-input-in-iframe.html to original behaviour after r248977 and make associated test autoscroll-input-when-very-zoomed.html more stable
https://bugs.webkit.org/show_bug.cgi?id=201058
Reviewed by Simon Fraser.
delete-in-input-in-iframe and typing-in-input-in-iframe were changed when scrolling was made to work differently in r244141.
They actually did find a bug, and that bug was fixed in r248977, so we put the tests back to test that scolls do not happen.
Also update autoscroll-input-when-very-zoomed which was added to test r248977 to be more robust.
* fast/forms/ios/delete-in-input-in-iframe-expected.txt:
* fast/forms/ios/delete-in-input-in-iframe.html:
* fast/forms/ios/typing-in-input-in-iframe-expected.txt:
* fast/forms/ios/typing-in-input-in-iframe.html:
* fast/scrolling/ios/autoscroll-input-when-very-zoomed.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (249041 => 249042)
--- trunk/LayoutTests/ChangeLog 2019-08-23 04:34:00 UTC (rev 249041)
+++ trunk/LayoutTests/ChangeLog 2019-08-23 07:25:00 UTC (rev 249042)
@@ -1,3 +1,20 @@
+2019-08-23 Megan Gardner <[email protected]>
+
+ Revert delete-in-input-in-iframe.html and typing-in-input-in-iframe.html to original behaviour after r248977 and make associated test autoscroll-input-when-very-zoomed.html more stable
+ https://bugs.webkit.org/show_bug.cgi?id=201058
+
+ Reviewed by Simon Fraser.
+
+ delete-in-input-in-iframe and typing-in-input-in-iframe were changed when scrolling was made to work differently in r244141.
+ They actually did find a bug, and that bug was fixed in r248977, so we put the tests back to test that scolls do not happen.
+ Also update autoscroll-input-when-very-zoomed which was added to test r248977 to be more robust.
+
+ * fast/forms/ios/delete-in-input-in-iframe-expected.txt:
+ * fast/forms/ios/delete-in-input-in-iframe.html:
+ * fast/forms/ios/typing-in-input-in-iframe-expected.txt:
+ * fast/forms/ios/typing-in-input-in-iframe.html:
+ * fast/scrolling/ios/autoscroll-input-when-very-zoomed.html:
+
2019-08-22 Fujii Hironori <[email protected]>
[SVG] -webkit-clip-path treats url(abc#xyz) as url(#xyz) because it checks only URL fragment part
Modified: trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe-expected.txt (249041 => 249042)
--- trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe-expected.txt 2019-08-23 04:34:00 UTC (rev 249041)
+++ trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe-expected.txt 2019-08-23 07:25:00 UTC (rev 249042)
@@ -1,5 +1,5 @@
Tests that typing into a text input in an iframe should not scroll.
-PASS: page scrolled to 1143
+PASS: page did not scroll.
Click to focus input
Modified: trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe.html (249041 => 249042)
--- trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe.html 2019-08-23 04:34:00 UTC (rev 249041)
+++ trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe.html 2019-08-23 07:25:00 UTC (rev 249042)
@@ -39,7 +39,7 @@
function pageDidScroll()
{
- document.getElementById('result').textContent = 'PASS: page scrolled to ' + document.scrollingElement.scrollTop;
+ document.getElementById('result').textContent = 'FAIL: page scrolled to ' + document.scrollingElement.scrollTop;
}
function testTyping()
@@ -76,7 +76,7 @@
<p>Tests that typing into a text input in an iframe should not scroll.</p>
<div id="result">
- FAIL: page did not scroll.
+ PASS: page did not scroll.
</div>
<button id="target" _onclick_="buttonClicked()">Click to focus input</button>
Modified: trunk/LayoutTests/fast/forms/ios/typing-in-input-in-iframe-expected.txt (249041 => 249042)
--- trunk/LayoutTests/fast/forms/ios/typing-in-input-in-iframe-expected.txt 2019-08-23 04:34:00 UTC (rev 249041)
+++ trunk/LayoutTests/fast/forms/ios/typing-in-input-in-iframe-expected.txt 2019-08-23 07:25:00 UTC (rev 249042)
@@ -1,5 +1,5 @@
Tests that typing into a text input in an iframe should not scroll.
-PASS: page scrolled to 1143
+PASS: page did not scroll.
Click to focus input
Modified: trunk/LayoutTests/fast/forms/ios/typing-in-input-in-iframe.html (249041 => 249042)
--- trunk/LayoutTests/fast/forms/ios/typing-in-input-in-iframe.html 2019-08-23 04:34:00 UTC (rev 249041)
+++ trunk/LayoutTests/fast/forms/ios/typing-in-input-in-iframe.html 2019-08-23 07:25:00 UTC (rev 249042)
@@ -39,7 +39,7 @@
function pageDidScroll()
{
- document.getElementById('result').textContent = 'PASS: page scrolled to ' + document.scrollingElement.scrollTop;
+ document.getElementById('result').textContent = 'FAIL: page scrolled to ' + document.scrollingElement.scrollTop;
}
function testTyping()
@@ -76,7 +76,7 @@
<p>Tests that typing into a text input in an iframe should not scroll.</p>
<div id="result">
- FAIL: page did not scroll.
+ PASS: page did not scroll.
</div>
<button id="target" _onclick_="buttonClicked()">Click to focus input</button>
Modified: trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed.html (249041 => 249042)
--- trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed.html 2019-08-23 04:34:00 UTC (rev 249041)
+++ trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed.html 2019-08-23 07:25:00 UTC (rev 249042)
@@ -24,7 +24,7 @@
await UIHelper.immediateZoomToScale(3.284);
await UIHelper.immediateScrollTo(390, 390);
- await UIHelper.delayFor(200);
+ await Promise.all([UIHelper.ensureVisibleContentRectUpdate(), UIHelper.ensureStablePresentationUpdate()]);
var originalXOffset = window.pageXOffset;
var originalYOffset = window.pageYOffset;
@@ -35,7 +35,7 @@
var secondYOffset = window.pageYOffset;
// Scrolling is not immedate, wait until the viewport has time to adjust
- await UIHelper.delayFor(25);
+ await Promise.all([UIHelper.ensureVisibleContentRectUpdate(), UIHelper.ensurePresentationUpdate()]);
await UIHelper.enterText("a");
var finalXOffset = window.pageXOffset;
@@ -47,7 +47,7 @@
if ((originalXOffset == secondXOffset) || (originalYOffset == secondYOffset))
output += 'FAIL: page has failed to scrolled on the first input<br>';
if ((secondXOffset != finalXOffset) || (secondYOffset != finalYOffset))
- output += 'FAIL: page has scrolled on the secont input';
+ output += 'FAIL: page has scrolled on the second input';
}
output += '<br>';
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
