Title: [249043] trunk/Source/WebCore
- Revision
- 249043
- Author
- [email protected]
- Date
- 2019-08-23 03:53:00 -0700 (Fri, 23 Aug 2019)
Log Message
[GStreamer] Hole-punch build is broken
https://bugs.webkit.org/show_bug.cgi?id=200972
Reviewed by Žan Doberšek.
This patch fixes link issues when building with
USE_GSTREAMER_HOLEPUNCH enabled, the hole punch client destructor
was missing.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
Remove FAST_ALLOCATED annotation, because:
* platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:
it's now in the base class, along with a default destructor.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (249042 => 249043)
--- trunk/Source/WebCore/ChangeLog 2019-08-23 07:25:00 UTC (rev 249042)
+++ trunk/Source/WebCore/ChangeLog 2019-08-23 10:53:00 UTC (rev 249043)
@@ -1,3 +1,19 @@
+2019-08-23 Philippe Normand <[email protected]>
+
+ [GStreamer] Hole-punch build is broken
+ https://bugs.webkit.org/show_bug.cgi?id=200972
+
+ Reviewed by Žan Doberšek.
+
+ This patch fixes link issues when building with
+ USE_GSTREAMER_HOLEPUNCH enabled, the hole punch client destructor
+ was missing.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+ Remove FAST_ALLOCATED annotation, because:
+ * platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:
+ it's now in the base class, along with a default destructor.
+
2019-08-22 Fujii Hironori <[email protected]>
[SVG] -webkit-clip-path treats url(abc#xyz) as url(#xyz) because it checks only URL fragment part
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (249042 => 249043)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2019-08-23 07:25:00 UTC (rev 249042)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2019-08-23 10:53:00 UTC (rev 249043)
@@ -1125,7 +1125,6 @@
}
class GStreamerHolePunchClient : public TextureMapperPlatformLayerBuffer::HolePunchClient {
- WTF_MAKE_FAST_ALLOCATED;
public:
GStreamerHolePunchClient(GRefPtr<GstElement>&& videoSink) : m_videoSink(WTFMove(videoSink)) { };
void setVideoRectangle(const IntRect& rect) final { setRectangleToVideoSink(m_videoSink.get(), rect); }
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h (249042 => 249043)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h 2019-08-23 07:25:00 UTC (rev 249042)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h 2019-08-23 10:53:00 UTC (rev 249043)
@@ -66,9 +66,10 @@
std::unique_ptr<TextureMapperPlatformLayerBuffer> clone();
class HolePunchClient {
+ WTF_MAKE_FAST_ALLOCATED();
public:
+ virtual ~HolePunchClient() = default;
virtual void setVideoRectangle(const IntRect&) = 0;
- virtual ~HolePunchClient() = 0;
};
void setHolePunchClient(std::unique_ptr<HolePunchClient>&& client) { m_holePunchClient = WTFMove(client); }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
