Title: [252779] trunk/Tools
- Revision
- 252779
- Author
- [email protected]
- Date
- 2019-11-22 09:51:26 -0800 (Fri, 22 Nov 2019)
Log Message
run-webkit-tests: Failing to run spindump shouldn't be fatal
https://bugs.webkit.org/show_bug.cgi?id=204518
<rdar://problem/57397417>
Reviewed by Aakash Jain.
* Scripts/webkitpy/port/darwin.py:
(DarwinPort.sample_process): Catch script error.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (252778 => 252779)
--- trunk/Tools/ChangeLog 2019-11-22 17:25:29 UTC (rev 252778)
+++ trunk/Tools/ChangeLog 2019-11-22 17:51:26 UTC (rev 252779)
@@ -1,3 +1,14 @@
+2019-11-22 Jonathan Bedard <[email protected]>
+
+ run-webkit-tests: Failing to run spindump shouldn't be fatal
+ https://bugs.webkit.org/show_bug.cgi?id=204518
+ <rdar://problem/57397417>
+
+ Reviewed by Aakash Jain.
+
+ * Scripts/webkitpy/port/darwin.py:
+ (DarwinPort.sample_process): Catch script error.
+
2019-11-22 Paulo Matos <[email protected]>
Remove JSC 32bit ARMv7 and MipsEl old EWS queues
Modified: trunk/Tools/Scripts/webkitpy/port/darwin.py (252778 => 252779)
--- trunk/Tools/Scripts/webkitpy/port/darwin.py 2019-11-22 17:25:29 UTC (rev 252778)
+++ trunk/Tools/Scripts/webkitpy/port/darwin.py 2019-11-22 17:51:26 UTC (rev 252779)
@@ -186,7 +186,7 @@
host.executive.run_command(spindump_command)
host.filesystem.move_to_base_host(DarwinPort.tailspin_file_path(host, name, pid, str(tempdir)),
DarwinPort.tailspin_file_path(self.host, name, pid, self.results_directory()))
- except IOError as e:
+ except (IOError, ScriptError) as e:
_log.warning('Unable to symbolicate tailspin log of process:' + str(e))
else: # Tailspin failed, run sample instead
try:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
