Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/config.json (252779 => 252780)
--- trunk/Tools/BuildSlaveSupport/ews-build/config.json 2019-11-22 17:51:26 UTC (rev 252779)
+++ trunk/Tools/BuildSlaveSupport/ews-build/config.json 2019-11-22 18:02:13 UTC (rev 252780)
@@ -273,6 +273,18 @@
{
"name": "ews215",
"platform": "win"
+ },
+ {
+ "name": "webkit-cq-01",
+ "platform": "mac-highsierra"
+ },
+ {
+ "name": "webkit-cq-02",
+ "platform": "mac-highsierra"
+ },
+ {
+ "name": "webkit-cq-03",
+ "platform": "mac-highsierra"
}
],
"builders": [
@@ -493,6 +505,16 @@
"factory": "ServicesFactory",
"platform": "*",
"workernames": ["ews151", "webkit-misc"]
+ },
+ {
+ "name": "Commit-Queue",
+ "shortname": "commit",
+ "icon": "buildAndTest",
+ "factory": "CommitQueueFactory",
+ "platform": "mac-highsierra",
+ "configuration": "release",
+ "architectures": ["x86_64"],
+ "workernames": ["webkit-cq-01", "webkit-cq-02", "webkit-cq-03"]
}
],
"schedulers": [
@@ -506,6 +528,12 @@
},
{
"type": "Try_Userpass",
+ "name": "try_commitqueue",
+ "port": 5557,
+ "builderNames": ["Commit-Queue"]
+ },
+ {
+ "type": "Try_Userpass",
"name": "disabled",
"port": 5556,
"builderNames": ["Windows-EWS"]
Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (252779 => 252780)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2019-11-22 17:51:26 UTC (rev 252779)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2019-11-22 18:02:13 UTC (rev 252780)
@@ -184,3 +184,8 @@
self.addStep(RunEWSUnitTests())
self.addStep(RunEWSBuildbotCheckConfig())
self.addStep(RunBuildWebKitOrgUnitTests())
+
+
+class CommitQueueFactory(Factory):
+ pass
+ # TODO: add appropriate build-steps for commit-queue
Modified: trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py (252779 => 252780)
--- trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py 2019-11-22 17:51:26 UTC (rev 252779)
+++ trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py 2019-11-22 18:02:13 UTC (rev 252780)
@@ -30,7 +30,7 @@
from buildbot.worker import Worker
from buildbot.util import identifiers as buildbot_identifiers
-from factories import (APITestsFactory, BindingsFactory, BuildFactory, Factory, GTKFactory,
+from factories import (APITestsFactory, BindingsFactory, BuildFactory, CommitQueueFactory, Factory, GTKFactory,
JSCTestsFactory, StyleFactory, TestFactory, WPEFactory, WebKitPerlFactory,
WebKitPyFactory, WinCairoFactory, WindowsFactory, iOSBuildFactory, iOSTestsFactory,
macOSBuildFactory, macOSWK1Factory, macOSWK2Factory, ServicesFactory, WatchListFactory)
Modified: trunk/Tools/ChangeLog (252779 => 252780)
--- trunk/Tools/ChangeLog 2019-11-22 17:51:26 UTC (rev 252779)
+++ trunk/Tools/ChangeLog 2019-11-22 18:02:13 UTC (rev 252780)
@@ -1,3 +1,14 @@
+2019-11-22 Aakash Jain <[email protected]>
+
+ [ews] Add basic commit-queue support in new EWS
+ https://bugs.webkit.org/show_bug.cgi?id=204517
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/config.json:
+ * BuildSlaveSupport/ews-build/factories.py:
+ * BuildSlaveSupport/ews-build/loadConfig.py:
+
2019-11-22 Jonathan Bedard <[email protected]>
run-webkit-tests: Failing to run spindump shouldn't be fatal