Title: [252782] trunk/Source/WebKit
- Revision
- 252782
- Author
- [email protected]
- Date
- 2019-11-22 10:41:33 -0800 (Fri, 22 Nov 2019)
Log Message
Remove -[_WKThumbnailView usesSnapshot/setUsesSnapshot:]
https://bugs.webkit.org/show_bug.cgi?id=150099
Reviewed by Tim Horton.
Remove some unused, no-op SPI. While we're here, remove a couple unneeded explicit
property syntheses.
* UIProcess/API/Cocoa/_WKThumbnailView.h:
* UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView setUsesSnapshot:]): Deleted.
(-[_WKThumbnailView usesSnapshot]): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (252781 => 252782)
--- trunk/Source/WebKit/ChangeLog 2019-11-22 18:25:55 UTC (rev 252781)
+++ trunk/Source/WebKit/ChangeLog 2019-11-22 18:41:33 UTC (rev 252782)
@@ -1,3 +1,18 @@
+2019-11-22 Conrad Shultz <[email protected]>
+
+ Remove -[_WKThumbnailView usesSnapshot/setUsesSnapshot:]
+ https://bugs.webkit.org/show_bug.cgi?id=150099
+
+ Reviewed by Tim Horton.
+
+ Remove some unused, no-op SPI. While we're here, remove a couple unneeded explicit
+ property syntheses.
+
+ * UIProcess/API/Cocoa/_WKThumbnailView.h:
+ * UIProcess/API/Cocoa/_WKThumbnailView.mm:
+ (-[_WKThumbnailView setUsesSnapshot:]): Deleted.
+ (-[_WKThumbnailView usesSnapshot]): Deleted.
+
2019-11-22 Chris Dumez <[email protected]>
Speculative loading sometimes happens too early and is missing login cookies
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.h (252781 => 252782)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.h 2019-11-22 18:25:55 UTC (rev 252781)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.h 2019-11-22 18:41:33 UTC (rev 252782)
@@ -51,9 +51,6 @@
@property (strong, nonatomic) NSColor *overrideBackgroundColor;
-// This should be removed when all clients go away; it is always YES now.
-@property (nonatomic) BOOL usesSnapshot;
-
- (void)requestSnapshot;
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm (252781 => 252782)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm 2019-11-22 18:25:55 UTC (rev 252781)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm 2019-11-22 18:41:33 UTC (rev 252782)
@@ -59,10 +59,7 @@
RetainPtr<NSColor> _overrideBackgroundColor;
}
-@synthesize snapshotSize=_snapshotSize;
@synthesize _waitingForSnapshot=_waitingForSnapshot;
-@synthesize exclusivelyUsesSnapshot=_exclusivelyUsesSnapshot;
-@synthesize shouldKeepSnapshotWhenRemovedFromSuperview=_shouldKeepSnapshotWhenRemovedFromSuperview;
- (instancetype)initWithFrame:(NSRect)frame
{
@@ -266,16 +263,6 @@
[self _requestSnapshotIfNeeded];
}
-// This should be removed when all clients go away; it is always YES now.
-- (void)setUsesSnapshot:(BOOL)usesSnapshot
-{
-}
-
-- (BOOL)usesSnapshot
-{
- return YES;
-}
-
- (void)_setThumbnailLayer:(CALayer *)layer
{
self.layer.sublayers = layer ? @[ layer ] : @[ ];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
