Title: [252781] trunk/Tools
Revision
252781
Author
[email protected]
Date
2019-11-22 10:25:55 -0800 (Fri, 22 Nov 2019)

Log Message

run-_javascript_core-tests: Hide the output of binaries behind --verbose
https://bugs.webkit.org/show_bug.cgi?id=204386

Reviewed by Aakash Jain.

* Scripts/run-_javascript_core-tests:
(runTest): Do not log binary output by default, always log test failures.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (252780 => 252781)


--- trunk/Tools/ChangeLog	2019-11-22 18:02:13 UTC (rev 252780)
+++ trunk/Tools/ChangeLog	2019-11-22 18:25:55 UTC (rev 252781)
@@ -1,3 +1,13 @@
+2019-11-22  Jonathan Bedard  <[email protected]>
+
+        run-_javascript_core-tests: Hide the output of binaries behind --verbose
+        https://bugs.webkit.org/show_bug.cgi?id=204386
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/run-_javascript_core-tests:
+        (runTest): Do not log binary output by default, always log test failures.
+
 2019-11-22  Aakash Jain  <[email protected]>
 
         [ews] Add basic commit-queue support in new EWS

Modified: trunk/Tools/Scripts/run-_javascript_core-tests (252780 => 252781)


--- trunk/Tools/Scripts/run-_javascript_core-tests	2019-11-22 18:02:13 UTC (rev 252780)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2019-11-22 18:25:55 UTC (rev 252781)
@@ -525,7 +525,7 @@
     open(TEST, "-|", "@command 2>&1") or die "Failed to run @command";
     while ( my $line = <TEST> ) {
         my $subTestName;
-        print $line;
+        print $line if ($verbose);
 
         # e.g.: 'O2: testRotRWithImmShift(uint64-max, uint32-min): OK!''
         if ($line =~ /(O\d): (\S+)(\(.*\)): ([A-Za-z]+)!\n/) {
@@ -588,7 +588,7 @@
         }
 
         if (!defined $reportData{$subTestName}) {
-            print("$subTestName $failureFlag\n") if $failureFlag;
+            print "$subTestName failed\n" if ($failureFlag && !$verbose);
             $reportData{$subTestName} = $failureFlag ? {actual => "FAIL"} : {actual => "PASS"};
         }
         $failureFlag = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to