Title: [252821] trunk/LayoutTests
- Revision
- 252821
- Author
- [email protected]
- Date
- 2019-11-22 18:14:02 -0800 (Fri, 22 Nov 2019)
Log Message
http/tests/eventloop/queue-task-across-cross-site-frames.html is flaky failure on iOS
https://bugs.webkit.org/show_bug.cgi?id=204510
Reviewed by Chris Dumez.
There are two issues with this test. First, queue-task-across-cross-site-frames.html wasn't waiting
for the helper file to post logs, and secondly, eventloop-helper.html was relying on setTimeout(~, 0)
to always happen after queued tasks had run, which is not always true if there had already been
another 0s timer scheduled.
* http/tests/eventloop/queue-task-across-cross-site-frames.html:
* http/tests/eventloop/resources/eventloop-helper.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (252820 => 252821)
--- trunk/LayoutTests/ChangeLog 2019-11-23 01:53:19 UTC (rev 252820)
+++ trunk/LayoutTests/ChangeLog 2019-11-23 02:14:02 UTC (rev 252821)
@@ -1,3 +1,18 @@
+2019-11-22 Ryosuke Niwa <[email protected]>
+
+ http/tests/eventloop/queue-task-across-cross-site-frames.html is flaky failure on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=204510
+
+ Reviewed by Chris Dumez.
+
+ There are two issues with this test. First, queue-task-across-cross-site-frames.html wasn't waiting
+ for the helper file to post logs, and secondly, eventloop-helper.html was relying on setTimeout(~, 0)
+ to always happen after queued tasks had run, which is not always true if there had already been
+ another 0s timer scheduled.
+
+ * http/tests/eventloop/queue-task-across-cross-site-frames.html:
+ * http/tests/eventloop/resources/eventloop-helper.html:
+
2019-11-22 Eric Carlson <[email protected]>
( r251737 ) media/remoteplayback-prompt.html is a flakey timeout
Modified: trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html (252820 => 252821)
--- trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html 2019-11-23 01:53:19 UTC (rev 252820)
+++ trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html 2019-11-23 02:14:02 UTC (rev 252821)
@@ -52,6 +52,8 @@
startingNumber: 10,
}, '*');
+ await new Promise((resolve) => { window.resolveCrossOriginLogs = resolve; });
+
setTimeout(() => {
shouldBeEqualToString('logs.join(", ")', '1, 2, 3, 4, 5');
shouldBeEqualToString('crossOriginLogs.join(", ")', '10, 11, 12');
@@ -67,8 +69,10 @@
resolve();
else
loadedFrames.set(event.source, null);
- } else if (event.data.type == 'logs')
+ } else if (event.data.type == 'logs') {
crossOriginLogs = event.data.logs;
+ resolveCrossOriginLogs();
+ }
}
function waitForLoad(frame)
Modified: trunk/LayoutTests/http/tests/eventloop/resources/eventloop-helper.html (252820 => 252821)
--- trunk/LayoutTests/http/tests/eventloop/resources/eventloop-helper.html 2019-11-23 01:53:19 UTC (rev 252820)
+++ trunk/LayoutTests/http/tests/eventloop/resources/eventloop-helper.html 2019-11-23 02:14:02 UTC (rev 252821)
@@ -17,7 +17,7 @@
setTimeout(() => {
top.postMessage({'type': 'logs', logs}, '*');
- }, 0);
+ }, 20);
}
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
