Title: [252822] trunk/Tools
Revision
252822
Author
[email protected]
Date
2019-11-22 18:25:44 -0800 (Fri, 22 Nov 2019)

Log Message

run-_javascript_core-tests: Failure to determine configuration for reporting is fatal
https://bugs.webkit.org/show_bug.cgi?id=204526

Reviewed by Aakash Jain.

* Scripts/run-_javascript_core-tests:
(configurationForUpload): Use uname as the default upload configuration

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (252821 => 252822)


--- trunk/Tools/ChangeLog	2019-11-23 02:14:02 UTC (rev 252821)
+++ trunk/Tools/ChangeLog	2019-11-23 02:25:44 UTC (rev 252822)
@@ -1,5 +1,15 @@
 2019-11-22  Jonathan Bedard  <[email protected]>
 
+        run-_javascript_core-tests: Failure to determine configuration for reporting is fatal
+        https://bugs.webkit.org/show_bug.cgi?id=204526
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/run-_javascript_core-tests:
+        (configurationForUpload): Use uname as the default upload configuration 
+
+2019-11-22  Jonathan Bedard  <[email protected]>
+
         results.webkit.org/api/failures should return an error when no test-run is found for specified criteria
         https://bugs.webkit.org/show_bug.cgi?id=204385
         <rdar://problem/57334389>

Modified: trunk/Tools/Scripts/run-_javascript_core-tests (252821 => 252822)


--- trunk/Tools/Scripts/run-_javascript_core-tests	2019-11-23 02:14:02 UTC (rev 252821)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2019-11-23 02:25:44 UTC (rev 252822)
@@ -389,12 +389,6 @@
             chomp($version = `uname -r`);
             $version = splitVersionString($version);
         }
-    } elsif (isJSCOnly()) {
-        $platform = 'jsc-only';
-        if (!$version) {
-            chomp($version = `uname -r`);
-            $version = splitVersionString($version);
-        }
     } elsif (isAnyWindows()) {
         $platform = 'win';
         if (!$version) {
@@ -420,7 +414,14 @@
             }
         }
     } else {
-        die "Cannot determine platform\n";
+        # FIXME: This will be the kernel version, which is not always exactly what we want, but it will at least
+        # always give us something to work with
+        chomp($platform = `uname`);
+        $platform = lc $platform;
+        if (!$version) {
+            chomp($version = `uname -r`);
+            $version = splitVersionString($version);
+        }
     }
 
     my $result = {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to